Skip to content

Fix #14720 FP assertWithSideEffect (const function call QDir::exists() in assert) #8526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

Fix #14720 FP assertWithSideEffect (const function call QDir::exists() in assert) #8526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cfg/qt.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2428,6 +2428,7 @@
<!-- bool QDir::exists() const -->
<function name="QDir::exists">
<noreturn>false</noreturn>
<pure/>
<returnValue type="bool"/>
<use-retval/>
<leak-ignore/>
Expand All @@ -2440,6 +2441,7 @@
<!-- bool QFile::exists() const -->
<function name="QFile::exists">
<noreturn>false</noreturn>
<pure/>
<returnValue type="bool"/>
<use-retval/>
<leak-ignore/>
Expand Down
5 changes: 5 additions & 0 deletions test/cfg/qt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,11 @@ void ignoredReturnValue_QDir(const QString& dirname)
dir.entryList();
}

void assertWithSideEffect_QDir_exists(const char *path) { // #14720
QDir dir(path);
assert(dir.exists());
(void)dir;
}

void unusedVariable_QTransform()
{
Expand Down
Loading