Skip to content

enabled and mitigated performance-avoid-endl clang-tidy warnings#6239

Draft
firewave wants to merge 1 commit intocppcheck-opensource:mainfrom
firewave:tidy-endl
Draft

enabled and mitigated performance-avoid-endl clang-tidy warnings#6239
firewave wants to merge 1 commit intocppcheck-opensource:mainfrom
firewave:tidy-endl

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

@firewave firewave commented Apr 5, 2024

This will also help with reducing valueFlowBailoutIncompleteVar warnings in our code base.

@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented Apr 5, 2024

There is most likely some explicit flushes to be added to have a good CLI experience. I have not looked into it yet.

@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented Apr 5, 2024

It seems the missing flushes somehow expose a bug in the pipe communication in the ProcessExecutor:

reportOut - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_2.cpp ...
handleRead - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_2.cpp ...
reportOut - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_4.cpp ...
handleRead - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_2.cpp ...
handleRead - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_4.cpp ...
reportOut - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_1.qml ...
handleRead - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_2.cpp ...
handleRead - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_4.cpp ...
handleRead - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_1.qml ...
reportOut - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_3.qml ...
handleRead - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_2.cpp ...
handleRead - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_4.cpp ...
handleRead - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_1.qml ...
handleRead - Checking /tmp/pytest-of-user/pytest-8/test_markup_j0/test_3.qml ...

@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented Apr 5, 2024

I cannot reproduce it outside of the Python test so it must be related to subprocess.Popen().

Comment thread lib/symboldatabase.cpp
void SymbolDatabase::printVariable(const Variable *var, const char *indent) const
{
std::cout << indent << "mNameToken: " << tokenToString(var->nameToken(), mTokenizer) << std::endl;
std::cout << indent << "mNameToken: " << tokenToString(var->nameToken(), mTokenizer) << '\n';
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants