[shenxianpeng]

Summary

The nu run: scripts in action.yml expanded ${{ inputs.* }} and ${{ github.event.pull_request.* }} directly into the script text. This is the pattern zizmor reports as template-injection: a value with a quote in it becomes part of the script. This PR passes those values to each step with env: and reads them with $env.* instead, which is GitHub's recommended way.

• Every nu step that used an input now declares it under env: (INPUT_<NAME>, plus PR_HEAD_SHA / PR_HEAD_REPO), and runner.os / github.repository use the runner's RUNNER_OS / GITHUB_REPOSITORY.
• Each of those steps starts with a load-env line that sets any of its variables that are missing to "", so an empty input behaves the same as before on every runner.
• llvm.sh still gets no version argument when version is empty (it then installs its default), same as before.
• No change to inputs, outputs or behavior. The only ${{ }} left in action.yml is the cache step's with:.

Checked locally: zizmor --offline action.yml reports no findings (45 template-injection before); every step script passes nu --ide-check; the Run cpp-linter step run with a fake uv passes values with quotes and spaces (for example -DX='a b') through as single arguments, and still works when most inputs are unset.

Related Issues

None.

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of supplied settings across compiler installation, dependency setup, linting, pull request checkout, and automatic commits.
  • Existing version handling, lint options, branch and fork safeguards, staging behavior, commit defaults, and failure outcomes remain unchanged.

[github-actions]

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format (v16.0.6) reports: 2 file(s) not formatted

• docs/examples/demo/demo.cpp
• docs/examples/demo/demo.hpp

clang-tidy (v16.0.6) reports: 7 concern(s)

• docs/examples/demo/demo.cpp:3:10: warning: [modernize-deprecated-headers]

  inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead

  #include <stdio.h>
           ^~~~~~~~~
           <cstdio>

• docs/examples/demo/demo.cpp:8:5: warning: [modernize-use-trailing-return-type]

  use a trailing return type for this function

  int main(){
  ~~~ ^
  auto       -> int

• docs/examples/demo/demo.cpp:10:13: warning: [readability-braces-around-statements]

  statement should be inside braces

      for (;;) break;
              ^
               {

• docs/examples/demo/demo.cpp:13:5: warning: [cppcoreguidelines-pro-type-vararg]

  do not call c-style vararg functions

      printf("Hello world!\n");
      ^

• docs/examples/demo/demo.hpp:6:11: warning: [modernize-use-default-member-init]

  use default member initializer for 'useless'

      char* useless;
            ^
                   {"\0"}

• docs/examples/demo/demo.hpp:7:9: warning: [modernize-use-default-member-init]

  use default member initializer for 'numb'

      int numb;
          ^
              {0}

• docs/examples/demo/demo.hpp:11:11: warning: [modernize-use-trailing-return-type]

  use a trailing return type for this function

      void *not_useful(char *str){useless = str;}
      ~~~~~~^
      auto                        -> void *

Have any feedback or feature suggestions? Share it here.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: e4cbacf0-2718-4344-a36e-bb9ae5c2fd25

📥 Commits

Reviewing files that changed from the base of the PR and between 94bdce8 and ab927fe.

📒 Files selected for processing: 1

• action.yml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Walkthrough

The action now passes inputs to Nushell scripts through environment variables. The installation, dependency setup, checkout, lint, and auto-commit steps read those values from the environment and default unset inputs to empty strings.

Changes

Action input handling

Layer / File(s)	Summary
Compiler installation action.yml	Linux and macOS installation steps read the version from the environment to construct package and tool names. The Linux installer omits the version argument when the value is empty.
Dependency setup and tool selection action.yml	Dependency setup reads version, verbosity, tidy checks, and style from environment variables. Existing conditions for selecting clang-tidy and clang-format remain in place.
PR checkout and lint execution action.yml	The checkout and linter steps read inputs from environment variables. The linter builds its arguments from those values, and the Linux platform check reads RUNNER_OS.
Auto-commit formatted changes action.yml	The auto-commit step reads repository, extension, Git identity, commit message, and PR metadata values from the environment. Existing fork checks and fallback values remain in place.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to ab927

The changed action steps appear to preserve their input handling while avoiding direct interpolation into run scripts. No actionable merge risk remains after normal checks.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: passing action inputs to run steps through environment variables.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[2bndy5]

BTW, I think this approach (where each input is exported as a INPUT_* env var) is automatic for docker-based actions.