Repository navigation
Conversation
eisenwave
approved these changes
Nov 12, 2026
Member
There was a problem hiding this comment.
Seems like we're not globally consistent about it, but most sentinel() and iterator(), and some public constructors like zip_view() are defaulted without constexpr.
But I don't think we have any policy on this, and there is nothing objectively wrong with having that constexpr.
eisenwave
added
P2-Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These constructors do not need the
constexprspecifier because they are defaults, which is consistent with other parts of [ranges].