LWG parts of P2996R13 Reflection for C++26#8004
LWG parts of P2996R13 Reflection for C++26#8004eisenwave wants to merge 1 commit intocplusplus:mainfrom
Conversation
|
Forward-looking comment for the library part: The section labels for the library should be "meta.refl.*" (because shorter without loss of expression) and for the Also, "define_aggregate" could maybe become "def.aggr". |
b89923b to
e87c239
Compare
| %FIXME: I see the same in <algorithm> with a // see \ref{initializer.list.syn} comment | ||
| #include <initializer_list> |
There was a problem hiding this comment.
I think we should add // see \ref{initializer.list.syn} for consistency. Currently, such comment is added whenever <initializer_list> is included in the synopsis.
b0fb1eb to
8b92b03
Compare
8b92b03 to
a13cfe0
Compare
|
@eisenwave Do you already want review feedback, or is this still in "draft"? |
|
Thanks! |
0579faf to
5c723b4
Compare
|
Hmm, it has occurred to me that this is a pretty big change. Everybody expected it and no one is surprised, but when you're |
8846eea to
ec34c7e
Compare
I was gonna point it out if you didn't.. |
e623bbe to
306262f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
7363bba to
659f74d
Compare
|
You need to use \caret for ^ in "usual" source. You can use "^" in codeblocks with no problem. |
|
meta.reflection.operators: Any details we could help with? |
Good to know.
No, you cannot. Single carets are fine, but two carets are being treated as a Unicode escape or something, and they seem to have special meaning even inside our
Anyhow, I'm going to do a linear read-through and fix any obvious mistakes, and then mark this as ready-for-review. |
Well, there are plenty of uses of ^^ inside codeblocks here, and they work just fine: https://github.com/cplusplus/draft/pull/8008/files However, the codeblock environment kicks back into "regular" mode in code comments, so you need to use \caret\caret inside comments. |
659f74d to
3141300
Compare
You're right. I think I've had some unbalanced Anyhow, the PR is now ready for review. I have not fixed anything up because I'm under the impression that will only make things harder to review during the first pass. There are 59 FIXMEs to resolve. |
3141300 to
85da3d8
Compare
|
Thank you very much! I've moved both the core and the lib changes into #8008 for further review! |
Closes #7930 once the core part is also complete.
Also closes cplusplus/papers#1668.