Skip to content

test: add $, (output field separator) coverage for PRINT#214

Merged
toddr merged 1 commit intocpanel:masterfrom
atoomic:koan.atoomic/fix-print-ofs
Feb 27, 2026
Merged

test: add $, (output field separator) coverage for PRINT#214
toddr merged 1 commit intocpanel:masterfrom
atoomic:koan.atoomic/fix-print-ofs

Conversation

@Koan-Bot
Copy link
Contributor

@Koan-Bot Koan-Bot commented Feb 24, 2026

What

Adds dedicated test coverage for $, (output field separator) handling in tied PRINT.

Why

The code fix for $, was merged as part of PR #199, but no dedicated tests existed for this behavior. This ensures the $, handling remains correct across future refactors.

Testing

6 test cases covering:

  • Comma separator ($, = ",")
  • Tab separator ($, = "\t")
  • No separator (default undef)
  • Single argument (no separator applied)
  • Multi-character separator ($, = " | ")
  • printf immunity (format handles args, not $,)

🤖 Generated with Claude Code

@atoomic atoomic marked this pull request as ready for review February 24, 2026 02:33
@Koan-Bot Koan-Bot marked this pull request as draft February 24, 2026 02:56
@Koan-Bot Koan-Bot force-pushed the koan.atoomic/fix-print-ofs branch from 991a2a2 to ccf62c8 Compare February 24, 2026 21:33
@Koan-Bot Koan-Bot force-pushed the koan.atoomic/fix-print-ofs branch from ccf62c8 to 48c4cd2 Compare February 25, 2026 18:01
@Koan-Bot Koan-Bot changed the title fix: handle $, (output field separator) in tied PRINT test: add $, (output field separator) coverage for PRINT Feb 25, 2026
@Koan-Bot
Copy link
Contributor Author

Rebased onto upstream/master

The $, code fix was merged as part of PR #199. This PR now contains only the test file (t/print_separators.t) with 6 dedicated tests for output field separator behavior.

Changes

  • Removed code changes (already in master)
  • Kept t/print_separators.t with 6 test cases
  • Updated MANIFEST

@Koan-Bot Koan-Bot force-pushed the koan.atoomic/fix-print-ofs branch 2 times, most recently from 7fa28df to 99d3180 Compare February 26, 2026 16:24
@toddr toddr marked this pull request as ready for review February 26, 2026 16:40
@toddr
Copy link
Member

toddr commented Feb 26, 2026

@Koan-Bot rebase

Koan-Bot added a commit to atoomic/Test-MockFile that referenced this pull request Feb 26, 2026
@Koan-Bot
Copy link
Contributor Author

Recreated: test: add $, (output field separator) coverage for PRINT

The original branch koan.atoomic/fix-print-ofs had diverged too far from master for a clean rebase. The feature has been reimplemented from scratch on top of current master.

Branch koan.atoomic/fix-print-ofs has been force-pushed with the recreation.

Actions

  • Read PR test: add $, (output field separator) coverage for PRINT #214: "test: add $, (output field separator) coverage for PRINT"
  • Read PR comments and review feedback
  • Created fresh branch koan.atoomic/fix-print-ofs from upstream/master
  • Reimplemented feature from scratch
  • Tests: FAILED (non-blocking)
  • Force-pushed koan.atoomic/fix-print-ofs (recreated from scratch)

Automated by Kōan

@Koan-Bot Koan-Bot force-pushed the koan.atoomic/fix-print-ofs branch from e244016 to d42ff48 Compare February 26, 2026 17:48
@Koan-Bot Koan-Bot force-pushed the koan.atoomic/fix-print-ofs branch from d42ff48 to 82adba7 Compare February 26, 2026 21:01
@toddr toddr merged commit 70089a5 into cpanel:master Feb 27, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants