Fix "Send RangeLink" ctx menu item missing in devcontainers // fixes #679#686
Fix "Send RangeLink" ctx menu item missing in devcontainers // fixes #679#686lourot wants to merge 1 commit into
Conversation
WalkthroughRangeLink now recognizes ChangesRemote workspace support
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/rangelink-vscode-extension/src/__tests__/constants/packageJsonContracts.test.ts (1)
1047-1155: 📐 Maintainability & Code Quality | 🔵 TrivialPotential QA test plan coverage gap for remote workspace context menus.
This PR adds user-visible behavior — RangeLink context menu items now appear in devcontainers and other remote workspaces (
vscode-remotescheme). Per path instructions, when changes inpackages/rangelink-vscode-extension/src/**modify user-visible behavior (new/changed context menu entries), the QA test plan YAML (packages/rangelink-vscode-extension/qa/qa-test-cases-*.yaml) should also be updated. No QA YAML changes are included in this PR.Suggested QA test case scenarios to add:
Context menu visibility in devcontainer — Preconditions: VS Code connected to a devcontainer. Steps: Open a text file from the remote workspace, right-click in the editor. Expected: RangeLink copy/paste/bind context menu items appear. Automated:
falseContext menu visibility in SSH remote workspace — Preconditions: VS Code connected via Remote-SSH. Steps: Open a text file, right-click in the editor and on the editor tab. Expected: RangeLink context menu items appear in both
editor/contextandeditor/title/context. Automated:falseBind text editor in remote workspace — Preconditions: VS Code in devcontainer, two text files open. Steps: Bind one editor, paste link into the other. Expected: Binding and paste succeed without read-only error. Automated:
falseContext menu items absent for read-only schemes — Preconditions: Open a
git:oroutput:document. Steps: Right-click in editor. Expected: RangeLink context menu items do NOT appear. Automated:falseAs per path instructions: "When reviewing changes in the VS Code extension source code, check whether the QA test plan YAML was also updated in this PR. Flag a potential QA coverage gap if the PR modifies user-visible behavior (new commands, changed UI text, new settings, new keybindings, new context menu entries, changed error messages, or new notifications) and the PR does NOT add or modify test cases in the QA YAML and the change is not purely internal."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/rangelink-vscode-extension/src/__tests__/constants/packageJsonContracts.test.ts` around lines 1047 - 1155, Add or update the relevant QA test plan YAML for the remote workspace context-menu behavior introduced in the editor context and editor title context contributions. Cover devcontainer and Remote-SSH visibility, remote bind/paste behavior, and absence on read-only schemes such as git and output, marking these scenarios as manual (automated: false).Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@packages/rangelink-vscode-extension/src/__tests__/constants/packageJsonContracts.test.ts`:
- Around line 1047-1155: Add or update the relevant QA test plan YAML for the
remote workspace context-menu behavior introduced in the editor context and
editor title context contributions. Cover devcontainer and Remote-SSH
visibility, remote bind/paste behavior, and absence on read-only schemes such as
git and output, marking these scenarios as manual (automated: false).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: fd4736b1-7dbf-44d6-8628-ba27e5392d26
📒 Files selected for processing (5)
packages/rangelink-vscode-extension/CHANGELOG.mdpackages/rangelink-vscode-extension/package.jsonpackages/rangelink-vscode-extension/src/__tests__/constants/packageJsonContracts.test.tspackages/rangelink-vscode-extension/src/utils/__tests__/isWritableScheme.test.tspackages/rangelink-vscode-extension/src/utils/isWritableScheme.ts
Summary by CodeRabbit
New Features
Documentation