Fixed bug with disappearing on bounce cell (second from the last one in collection)#10
Open
Skogetroll wants to merge 1 commit intocorin8823:masterfrom
Open
Fixed bug with disappearing on bounce cell (second from the last one in collection)#10Skogetroll wants to merge 1 commit intocorin8823:masterfrom
Skogetroll wants to merge 1 commit intocorin8823:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In current state viewController's view is being removed in
didEndDisplayingand added onlycellForItemAt. For the cell next to last ones (or to be more correct ones on the edge of the collection: first and last one) on bouncedidEndDisplayinghappened, so view was removed, but cell had no need be created, so cell ended up without view in it.This fix just add view of viewController on
willDisplay, iff it's not already subview of the cell. So even cell loses subview ondidEndDisplayingduring bounce, it gets it back before displaying.Also,
@objcadded todidTapGesturebecause#selector()was demanding it.