Removing jQuery dependency for Bloodhound#162
Closed
jslegers wants to merge 7 commits intocorejavascript:masterfrom
jslegers:master
Closed
Removing jQuery dependency for Bloodhound#162jslegers wants to merge 7 commits intocorejavascript:masterfrom jslegers:master
jslegers wants to merge 7 commits intocorejavascript:masterfrom
jslegers:master
Conversation
* Removing jQuery from Bloodhound * Adding Jetty server * Adding demo page to "test"
Most importantlty, a Promise polyfill is added.
Contributor
|
👍 Would be interested in this, @jslegers, if you have more time to work on it. I imagine it is going to be a big job, especially to update all the unit tests. |
Author
Since you asked so nicely, I gave it another shot. This time, everything works as expected. To avoid including any garbage from my previous attempt, I reforked the project and created a new pull request with only the changes done during my new attempt. See #163. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Too many failed unit tests
Nevermind...