feat: sync metaschema-modules tables from constructive-db#85
Merged
Conversation
- add function_invocation_module (entity-scoped invocations + execution logs) - function_module: drop invocation/execution-log columns (extracted to function_invocation_module) - memberships_module: add permission_default_permissions_table_id, permission_default_grants_table_id - merkle_store_module: add function_prefix override - notifications_module: add suppressions_table_id + FK - regenerate sql bundle 0.26.3 -> 0.26.5, update control/Makefile, plan entry
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the schema-only
metaschema-modulespackage up to date with the latest table DDL inconstructive-db(the source of truth). One new module table plus four that drifted. Per the repo split, only theCREATE TABLEDDL lives here — triggers/functions stay downstream inconstructive-db.New table
function_invocation_module— entity-scoped function invocations + execution logs. Carriesinvocations_table_*/execution_logs_table_*, scope/prefix, optionalentity_table_idfor RLS/billing, pluspolicies/provisions/default_permissions. Added topgpm.plan(afterfunction_module) withverify_table()verify andDROP TABLErevert.Changed tables (in-place deploy DDL edits to match constructive-db)
function_module— removedinvocations_table_id,execution_logs_table_id,invocations_table_name,execution_logs_table_nameand their FKs (this responsibility was extracted into the newfunction_invocation_module).memberships_module— addedpermission_default_permissions_table_id,permission_default_grants_table_id(nullable).merkle_store_module— addedfunction_prefix text DEFAULT NULL(function-name prefix override).notifications_module— addedsuppressions_table_id+ FK (ON DELETE SET NULL) and its@fieldNamecomment.Packaging
sql/metaschema-modules--0.26.3.sql→--0.26.5.sqlviapgpm package, aligning the drifteddefault_version/Makefile(control was0.26.3whilepackage.jsonwas already0.26.5).package.jsonversion unchanged (repo uses synchronized versioning).Note:
agent_moduledeploy DDL is already identical upstream — no change. Theagent_chat_moduleverify/revert files (in neitherpgpm.plan) are pre-existing orphans and left untouched.Testing
pgpm test-packages --full-cycle— all 26 modules pass deploy → verify → revert → deploy, includingmetaschema-modules(new table deploys/verifies/reverts/redeploys cleanly).metaschema-modulesjest suite — 8/8 pass; 4 snapshots regenerated to reflect the new table + net +5 FK constraints (function_invocation_module +6, function_module −2, notifications +1).Link to Devin session: https://app.devin.ai/sessions/4c98e5fc9b7741d182314b5eeea33590
Requested by: @pyramation