feat: remove unused module column from metaschema_public tables#84
Merged
Conversation
The 'module text NULL' column was dead, write-only metadata on 14 metaschema_public table definitions. The downstream generators that populated it live in constructive-db; upstream here it has zero writers and zero readers, so it is a pure orphan column. - Drop 'module' from the 14 metaschema_public table DDLs - Remove 'module' from the view verify column list - Regenerate the sql/ bundle (control + Makefile aligned 0.26.3 -> 0.26.5 to match the package version)
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the dead
module text NULLcolumn from the 14metaschema_publictable definitions inmetaschema-schema. This column was write-only metadata with zero readers — the generators that populated it live downstream inconstructive-db, so here in the upstream schema-only package it has 0 writers and 0 readers, making it a pure orphan column definition. The matching deletion already landed downstream in constructive-db#1594; this upstreams the schema-only half.Per the repo's split (pgpm-modules = schema/table DDL only, triggers/functions live in constructive-db's
metaschema), only the table DDL belongs here.What changed
modulefrom 14metaschema_public/*/table.sqlDDLs:table,field,schema,view,index,policy,trigger,enum,composite_type,spatial_relation, and the 4 constraint tables (check_/unique_/foreign_key_/primary_key_constraint).category metaschema_public.object_category NOT NULL DEFAULT 'app', - module text NULL, scope int NULL,modulefrom the one verify that lists columns explicitly (view/table.sql); the other 13 useverify_table(...)which only asserts table existence:sql/bundle viapgpm package. This aligned the stale pg-extension version (control+Makefile)0.26.3 → 0.26.5to match the package version, and replacedmetaschema-schema--0.26.3.sqlwithmetaschema-schema--0.26.5.sql.The
'module'value of theobject_categoryenum and theservices_public/metaschema_modulesmodule tables are unrelated concepts and are untouched.Verification
pnpm test(metaschema-schema jest): passes — package deploys cleanly without the column.pgpm test-packages --full-cycle: all modules pass the deploy → verify → revert → deploy cycle, includingservices(which depends onmetaschema-schema).metaschema_public.*.modulecolumn.Link to Devin session: https://app.devin.ai/sessions/4c98e5fc9b7741d182314b5eeea33590
Requested by: @pyramation