Repository navigation
fix: match preflight CI check names to the Checks API - #749
yvonnedevlinrh merged 3 commits into
Conversation
marcusburghardt
left a comment
There was a problem hiding this comment.
The check-name corrections address the reported mismatch, and the change is appropriately scoped. Before merging:
- Fix the PR-caused ShellCheck failures in the new test while preserving its intended literal matching.
- Add behavioral regression coverage. Source-string assertions do not verify discovery output. Execute the actual discovery logic against fixtures covering direct jobs with explicit names, job-ID fallback, and the corrected shared linter check name. Avoid duplicating the implementation inside the tests.
- Update
openspec/specs/release-preflight/spec.md, whose discovery scenarios still describe the incorrect workflow-prefixed names.
The test’s runtime and dependencies are appropriately lightweight; the concern is regression protection, not performance.
This review was generated by /uf.review-pr (AI-assisted).
yvonnedevlinrh
left a comment
There was a problem hiding this comment.
Thanks for contributing this fix I also reviewed the changes and agree with Marcus’s feedback, the naming correction looks right, and behavioural tests would help protect it from regressions.
One small addition: please update the “CI Check Auto-Discovery” section in docs/RELEASE_WORKFLOWS.md alongside the spec, as its examples still use the old workflow-prefixed names.
7fb2f92 to
5d99da6
Compare
|
Addressed both reviews in 5d99da6. ShellCheck SC2016 — gone with the source-text assertions. The test file now passes Behavioral regression coverage —
Spec and docs — Checks on this push need a maintainer approval to run (fork PR), so I could not watch them complete. Locally: |
marcusburghardt
left a comment
There was a problem hiding this comment.
Please fix the ineffective prefix assertion before merging. The check-name corrections and other regression assertions are verified.
This review was generated by /uf.review-pr (AI-assisted).
5d99da6 to
3cea9c7
Compare
marcusburghardt
left a comment
There was a problem hiding this comment.
The check-name fixes address #684, and my earlier review requests are resolved. Both preflight test suites passed locally.
Several GitHub Actions workflows are awaiting approval; please ensure they pass before merging.
This review was generated by /uf.review-pr (AI-assisted).
| For `ci_local.yml`, the preflight uses `yq` to extract: | ||
| 1. The workflow `name:` field | ||
| 2. Each job key and its optional `name:` field | ||
| - A direct job is reported as its `name`, or as the job key when the job declares no `name`. |
There was a problem hiding this comment.
[MEDIUM] Matrix jobs can include matrix values in their check-run names, so auto-discovery may not match them. Please mention using the ci_checks override for matrix jobs.
The preflight auto-discovery prepended the calling workflow's name to each discovered check. The Checks API reports the bare job name for direct jobs and "<calling job> / <called job>" for reusable workflow calls, so the exact-match lookup never found the checks and blocked releases. Use the bare job name for ci_local.yml jobs and correct the hardcoded ci_checks.yml linter name. Add a regression test covering both paths. Fixes complytime#684 Assisted-by: Hermes Agent (longcat-2.5) Signed-off-by: SatriaBagusNurhadianto <kenzaarthur@gmail.com>
tests/test_preflight_check_discovery.sh was missing from the path filters, so a change to it alone would not run the preflight test job. Assisted-by: Hermes Agent (longcat-2.5) Signed-off-by: SatriaBagusNurhadianto <kenzaarthur@gmail.com>
The source-text assertions in test_preflight_check_discovery.sh could pass with the expected statements commented out or unreachable, and they failed on harmless renaming. They also tripped ShellCheck SC2016. Run the real "Discover CI checks" step against fixture repositories instead, covering named jobs, the job key fallback, the bare shared linter check and the explicit ci_checks override. yq is installed in the preflight test job so the ci_local.yml cases actually execute in CI. Document how GitHub names checks: the job name (or job key) for direct jobs, "<caller job> / <called job>" for reusable workflow calls, and never the workflow's top-level name. Update the release-preflight spec and RELEASE_WORKFLOWS.md accordingly. Assisted-by: Hermes Agent (longcat-2.5) Signed-off-by: Satria Bagus Nurhadianto <kenzaarthur@gmail.com>
3cea9c7 to
f38111e
Compare
yvonnedevlinrh
left a comment
There was a problem hiding this comment.
No blocking findings found
|



What changed:
ci_local.ymlnow records the bare job name instead of"<workflow name> / <job name>".ci_checks.ymllinter check is nowStandardized CI / Run lintersinstead ofCI / Standardized CI / Run linters.tests/test_preflight_check_discovery.shand wired it intoci_test_preflight.yml.Why:
"<calling job> / <called job>"for reusable calls. The extra workflow-name prefix made the exact-match lookup miss every check, so releases were blocked whenci_checkswas left empty.Tests:
bash tests/test_preflight_check_discovery.shpasses 4/4.actionlinton both changed workflows is clean.yamllinton normalized copies is clean. The local Windows checkout stores CRLF, so the raw working-tree files report a newline error; the committed blobs are LF.tests/test_preflight_token.shwas not run becauseyqis not installed in this environment. It is unrelated to this change.Fixes: #684