fix: fix security vulnerabilities - #210
Merged
Merged
Conversation
Resolve the Vanta/Dependabot alerts on js-yaml and brace-expansion, plus the remaining pnpm audit advisories: - js-yaml, brace-expansion and undici are fixed by refreshing the lockfile, since every dependent already allows the patched version - serialize-javascript needs an override, because mocha still pins a vulnerable range Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
cl-mvezzelli
approved these changes
Aug 17, 2026
Member
Author
|
🎉 This PR is included in version 6.9.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix security vulnerabilities
Closes #207
Resolves the open Dependabot/Vanta alerts on this repo, plus the remaining advisories surfaced by
pnpm audit.Alerts closed by this PR
brace-expansion>= 4.0.0, < 5.0.8(CVE-2026-14257)brace-expansion>= 2.0.0, < 2.1.3(CVE-2026-14257)brace-expansion>= 4.0.0, < 5.0.9(CVE-2026-69152)brace-expansion>= 2.0.0, < 2.1.4js-yaml>= 3.0.0, < 3.15.1(GHSA-5p4m-2wfm-xmqj)Issue #207 tracks alerts 149, 150, 156 and 165, with the earliest remediation deadline on 2026-08-31.
Additional advisories from
pnpm auditjs-yaml4.3.0!!omapDoSmocha,semantic-releaseundici7.28.0@semantic-release/githubundici6.27.0 / 7.28.0type, cookie attribute injection, cache-directive disclosure@actions/http-client,@semantic-release/githubserialize-javascript6.0.2RegExp.flags/Date.prototype.toISOString(), plus CPU-exhaustion DoSmochaHow each one is fixed
Lockfile refresh (no override needed). For
js-yaml,brace-expansionandundicievery dependent already declares a range that admits the patched release —^3.14.1,^4.1.0,^2.0.1,^5.0.x,^6.23.0,^7.0.0— so regeneratingpnpm-lock.yamlis enough. Nopackage.jsonchange is required. Theundiciadvisories are dev-only in any case: both copies come in throughsemantic-release, which only runs in CI.Override.
serialize-javascriptis the one exception:mochastill pins^6.0.2and the fix landed in 7.0.5, so the range cannot resolve to a patched version. It is declared inpnpm-workspace.yaml, since pnpm 11 no longer readspnpm.overridesfrompackage.json. The entry is scoped to the vulnerable range only (serialize-javascript@<7.0.5) and carries a comment with the reason, so it drops out naturally once mocha ships a fix.The bump is dev-only — mocha uses the package for parallel-mode worker serialization — and v7 requires Node >= 20, which matches this package's
engines.Verification
pnpm audit— no advisoriesbrace-expansion2.1.4 / 5.0.9 andjs-yaml3.15.1 / 4.3.1 remainpnpm build,pnpm test(27 passing),pnpm lint(biome, 67 files) — all pass./bin/run.js:--versionandapplicationsrun against the local config