Busnum - #69
Merged
Merged
Conversation
…ching on DeviceArg busnum() is only available on Linux. The cross-platform equivalent is bus_id(). * Linux: String version of the busnum (e.g. \"001\") * MacOS: Top byte of the location ID (e.g. \"01\") * Windows: Unsure In any case, it should be consistent with the output of the `list` command in the example
Run the tests on linux, windows and macos instead of just linux. Also pin each to specific OS versions to avoid issues when defaults change.
Let the example code recognize both numeric and string bus numbers. For platforms with numeric bus numbers that avoid matching exactly the bus format. In particular nusb uses a 3 digit, 0-prefixed number for the bus on linux (e.g. 003). This avoids the user having to put in `003` but allows using just `3` for the bus. As common is used by both examples, but the various functions might not be used by both... Sadly, a healthy does of allowing unused/dead_code is required avoid warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.