fix(vef-cli): use bun's Underscore for derived schema column names#2
Open
zouanbing wants to merge 1 commit into
Open
fix(vef-cli): use bun's Underscore for derived schema column names#2zouanbing wants to merge 1 commit into
zouanbing wants to merge 1 commit into
Conversation
extractColumnNameFromTag fell back to lo.SnakeCase when a field had no explicit column name (e.g. `bun:"type:jsonb"` or `bun:",nullzero"`). lo.SnakeCase inserts an underscore before digits (Name2 -> name_2), but bun derives the column with internal.Underscore, which does not (Name2 -> name2). The generated accessor then referenced a column that does not exist for any field whose name contains a digit. Replace the fallback with a local copy of bun's Underscore so generated column names match the columns bun reads and writes at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extractColumnNameFromTag fell back to lo.SnakeCase when a field had no explicit column name (e.g.
bun:"type:jsonb"orbun:",nullzero"). lo.SnakeCase inserts an underscore before digits (Name2 -> name_2), but bun derives the column with internal.Underscore, which does not (Name2 -> name2). The generated accessor then referenced a column that does not exist for any field whose name contains a digit.Replace the fallback with a local copy of bun's Underscore so generated column names match the columns bun reads and writes at runtime.