Open
Conversation
cb-ekuersch
force-pushed
the
floating-ui
branch
2 times, most recently
from
e6ea0a9 to
6ef58c2
Compare
cb-ekuersch
force-pushed
the
floating-ui
branch
from
6ef58c2 to
db94e61
Compare
…floating-ui and drop usePopper
cb-ekuersch
force-pushed
the
floating-ui
branch
from
db94e61 to
3443e50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Issue: https://linear.app/coinbase/issue/CDS-1258/remove-popperjs-and-react-popper
https://floating-ui.com/docs/migration#positioning-function-change
PopperJS was rebranded to Floating-UI. The library encompasses multiple packages and notably is cross-platform, supporting React Native positioning. Thankfully we already had Floating-UI as a dep so fully switching over is not a big investment.
usePopperwas dropped as it was only used by the Popover component. Customers importing this should use floating-ui directly. We could consider adding this as an official peer dep in the future.Root cause (required for bugfixes)
UI changes
Testing
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false