fix: clamp endLine to file length in line-based editor replacement#1066
Open
octo-patch wants to merge 1 commit intocodexu:devfrom
Open
fix: clamp endLine to file length in line-based editor replacement#1066octo-patch wants to merge 1 commit intocodexu:devfrom
octo-patch wants to merge 1 commit intocodexu:devfrom
Conversation
…nesInRange (fixes codexu#1054)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1054
Problem
When the AI uses
replace_editor_contentwith line-based mode (e.g.startLine: 1,endLine: totalLinesfor a document-wide rewrite), a minor line-count discrepancy between whatget_editor_contentreported and whateditor.getMarkdown()returns at replacement time causes an uncaught error:This happens because
editor.getMarkdown()normalises the content (e.g. strips trailing blank lines) so the actual line count can be slightly lower thantotalLinesthe AI received earlier.Solution
Instead of throwing when
endLineexceeds the file length, clampendLineto the last line of the file. This preserves the intent of the operation ("replace up to the end of the document") without crashing.The same fix is applied to
deleteLinesInRangefor consistency.Testing
endLineis slightly larger than the current line count.