Repository navigation
Apply formatting and fix lint and type errors - #192
Merged
Merged
Conversation
Smoss
commented
Sep 30, 2026
Comment on lines
113
to
116
| collected_at: str # ISO8601 UTC, assigned by orchestration | ||
| likes: int | None = None # likes/favourites | ||
| reposts: int | None = None # reposts/reblogs; None when unavailable | ||
| comments: int | None = None # replies/comments |
Collaborator
Author
There was a problem hiding this comment.
This was intentional, how can we preserve this in the linting rules?
This was referenced Sep 30, 2026
5 tasks
Smoss
force-pushed
the
smoss/format-and-lint-fixes
branch
from
October 14, 2026 00:26
8de8e90 to
dab1b01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies Ruff formatting and import sorting across the project and removes unused imports so the new development checks pass.
Resolves Pyright diagnostics with explicit path and payload types, assertions that successful parsing and metric collection returned values, a corrected manual fixture, and an accurate package export list. Handles Instagram HTTP errors without a response safely and adapts the Mastodon media list to the SDK type. Retains the intentional invalid-tag test with a narrowly scoped diagnostic suppression.
This PR is stacked on
smoss/lint-format-typing; merge the tooling PR first. Includes existing formatting changes to the metric collector specification's Python examples.Validation:
make format: completed; subsequent check confirms 44 files formatted.make lint: Ruff passes; Pyright reports 0 errors and 0 warnings.make test: 146 passed, 1 skipped (live API test without credentials).git diff --check: passed.