feat(rpc): handle extension requests directly - #822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Extension RPC was one-way: extensions could emit capability-gated state, but an RPC client could
not invoke extension-owned controls without turning them into slash-command prompts.
Fix
pi.rpc.handle(name, handler)registrationextension_requestJSONL command and structured responseRpcClient.requestExtension()Verification
npm --prefix packages/coding-agent test -- test/suite/rpc-extension-requests.test.ts test/suite/rpc-extension-events.test.ts test/rpc-multi-session.test.tsnpx tsc --noEmit --pretty falsenpm run buildnpm run checkModel:
gpt-5.6-sol-fastHarness:
omo-senpiSummary by cubic
Enables direct client-to-extension RPC requests so clients can call extension-owned handlers without the model. Adds a session-scoped RPC command and client API with strict validation, multi-session tagging, and rejection of stale or in-flight results after reloads.
New Features
pi.rpc.handle(name, handler)to register one handler per name on the active extension generation; rejects empty, unknown, duplicate, and stale-generation cases.extension_requestwith structured success/error responses; data is opaque; responses includesessionIdin multi-session mode.RpcClient.requestExtension(name, data?)to call a handler and get its result.Bug Fixes
ExtensionRunnerafter reload notifications.pi.rpc.emit()now asserts generation liveness before publishing.Written for commit 901171b. Summary will update on new commits.