-
Notifications
You must be signed in to change notification settings - Fork 15
chore: use @code-pushup/nx-plugin in repo #1091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
View your CI Pipeline Execution ↗ for commit 655b605
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
# Conflicts: # project.json
# Conflicts: # packages/nx-plugin/src/executors/cli/schema.json # packages/nx-plugin/src/executors/cli/schema.ts
Related to #1091 --------- Co-authored-by: John Doe <[email protected]>
# Conflicts: # e2e/nx-plugin-e2e/tests/executor-cli.e2e.test.ts # packages/nx-plugin/src/executors/cli/executor.ts
related to #1091 **This PR includes:** - alignments of terminal args helper - add command formatter helper to `utils` - reuse utils in `nx-plugin` and remove old code - remove bin logic from config target (left over of #1109) --------- Co-authored-by: John Doe <[email protected]>
# Conflicts: # e2e/nx-plugin-e2e/tests/plugin-create-nodes.e2e.test.ts # packages/nx-plugin/src/executors/cli/executor.int.test.ts # packages/nx-plugin/src/executors/cli/executor.unit.test.ts # packages/utils/src/index.ts # packages/utils/src/lib/logger.ts # packages/utils/src/lib/transform.unit.test.ts
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 38d1dd1 with previous commit a3fc6d0. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 1 group regressed, 👍 1 audit improved, 👎 5 audits regressed, 13 audits changed without impacting score🗃️ Groups
32 other groups are unchanged. 🛡️ Audits
660 other audits are unchanged. |
| "private": true, | ||
| "dependencies": { | ||
| "@axe-core/playwright": "^4.11.0", | ||
| "@code-pushup/cli": "^0.96.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to install it as it is a normal dependency, but in our nx.json we configure the execution of the local TS code.
| "@axe-core/playwright": "^4.11.0", | ||
| "@code-pushup/cli": "^0.96.1", | ||
| "@code-pushup/models": "^0.96.1", | ||
| "@code-pushup/nx-plugin": "^0.96.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to install it because ATM Nx plugins don't take import aliases in any way. This means our nx-plugin code is always 1 release behind the current PR
Precondition:
This PR includes:
Related:
closes #971
Changes where tested by:
npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1091nx.json{ "pluginsConfig": { "@code-pushup/nx-plugin": { "projectPrefix": "cli", "bin": "packages/cli/src/index.ts", "env": { "NODE_OPTIONS": "--import tsx", "TSX_TSCONFIG_PATH": "tsconfig.base.json" } } }, "plugins": [ { "plugin": "@code-pushup/nx-plugin", "options": { "targetName": "cp" } } ] }