Skip to content

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Aug 27, 2025

Precondition:

This PR includes:

  •  use plugin for main and cached targets
  • use executor on all targets
  • remove existing target configurations in projects
  • add docs
  • add validation helper script

Related:
closes #971

Changes where tested by:

  1. npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1091
  2. add plugin inc options to nx.json
{
  "pluginsConfig": {
    "@code-pushup/nx-plugin": {
      "projectPrefix": "cli",
      "bin": "packages/cli/src/index.ts",
      "env": {
        "NODE_OPTIONS": "--import tsx",
        "TSX_TSCONFIG_PATH": "tsconfig.base.json"
      }
    }
  },
  "plugins": [
    {
      "plugin": "@code-pushup/nx-plugin",
      "options": {
        "targetName": "cp"
      }
    }
  ]
}

@nx-cloud
Copy link

nx-cloud bot commented Aug 28, 2025

View your CI Pipeline Execution ↗ for commit 655b605

Command Status Duration Result
nx run-many --targets=code-pushup --parallel=fa... ❌ Failed 14m 40s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 46s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-16 19:15:30 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 28, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1091

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1091

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1091

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1091

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1091

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1091

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1091

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1091

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1091

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1091

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1091

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1091

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1091

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1091

commit: 655b605

@github-actions github-actions bot added the 📖 Project documentation improvements or additions to the project documentation label Sep 4, 2025
# Conflicts:
#	packages/nx-plugin/src/executors/cli/schema.json
#	packages/nx-plugin/src/executors/cli/schema.ts
@BioPhoton BioPhoton marked this pull request as ready for review September 4, 2025 14:23
BioPhoton added a commit that referenced this pull request Dec 2, 2025
Related to #1091

---------

Co-authored-by: John Doe <[email protected]>
# Conflicts:
#	e2e/nx-plugin-e2e/tests/executor-cli.e2e.test.ts
#	packages/nx-plugin/src/executors/cli/executor.ts
BioPhoton added a commit that referenced this pull request Dec 2, 2025
related to #1091 

**This PR includes:**
- alignments of terminal args helper
- add command formatter helper to `utils`
- reuse utils in `nx-plugin` and remove old code
- remove bin logic from config target (left over of #1109)

---------

Co-authored-by: John Doe <[email protected]>
Michael Hladky added 2 commits December 4, 2025 21:11
# Conflicts:
#	e2e/nx-plugin-e2e/tests/plugin-create-nodes.e2e.test.ts
#	packages/nx-plugin/src/executors/cli/executor.int.test.ts
#	packages/nx-plugin/src/executors/cli/executor.unit.test.ts
#	packages/utils/src/index.ts
#	packages/utils/src/lib/logger.ts
#	packages/utils/src/lib/transform.unit.test.ts
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 38d1dd1 with previous commit a3fc6d0.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 42 🔴 38 ↓ −4.4
Updates 🟡 71 🟡 74 ↑ +2.8
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Bug prevention 🟡 67 🟡 67
Code style 🟢 99 🟢 99
Code coverage 🟡 89 🟡 89
Security 🔴 43 🔴 43
Type Safety 🟡 56 🟡 56
Miscellaneous 🟡 67 🟡 67
Documentation 🔴 35 🔴 35
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👍 1 group improved, 👎 1 group regressed, 👍 1 audit improved, 👎 5 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 42 🔴 38 ↓ −4.4
JS Packages NPM outdated dependencies 🟡 71 🟡 74 ↑ +2.8

32 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟩 Root document took 470 ms 🟥 Root document took 650 ms ↑ +37.1 %
Lighthouse Speed Index 🟨 5.6 s 🟥 6.5 s ↑ +14.7 %
Lighthouse Total Blocking Time 🟥 1,120 ms 🟥 1,430 ms ↑ +27 %
Lighthouse First Contentful Paint 🟨 3.0 s 🟥 3.2 s ↑ +7.5 %
JS Packages Outdated NPM prod dependencies. 🟨 18 outdated package versions (7 major, 8 minor, 3 patch) 🟨 18 outdated package versions (7 major, 8 minor, 3 patch)  +0 %
Lighthouse Time to Interactive 🟥 12.2 s 🟥 12.4 s ↑ +2 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,041 KiB 🟩 Total size was 2,054 KiB ↑ +0.6 %
Lighthouse Minimizes main-thread work 🟥 7.6 s 🟥 9.4 s ↑ +24.9 %
Lighthouse JavaScript execution time 🟥 3.0 s 🟥 4.3 s ↑ +40.3 %
Lighthouse Server Backend Latencies 🟩 90 ms 🟩 790 ms ↑ +732.2 %
Lighthouse Largest Contentful Paint 🟥 11.1 s 🟥 11.5 s ↑ +3.3 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +2 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 95 KiB 🟥 Potential savings of 95 KiB ↓ −33.3 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 189 KiB 🟥 Potential savings of 189 KiB ↓ −15.6 %
Lighthouse Max Potential First Input Delay 🟥 1,060 ms 🟥 1,160 ms ↑ +9.8 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↓ −0.1 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 10 ms ↓ −0.2 %
Code coverage Branch coverage 🟨 87.2 % 🟨 87.2 % ↓ −0.1 %
Lighthouse Cumulative Layout Shift 🟩 0 🟩 0.001 ↑ +∞ %

660 other audits are unchanged.

"private": true,
"dependencies": {
"@axe-core/playwright": "^4.11.0",
"@code-pushup/cli": "^0.96.1",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to install it as it is a normal dependency, but in our nx.json we configure the execution of the local TS code.

"@axe-core/playwright": "^4.11.0",
"@code-pushup/cli": "^0.96.1",
"@code-pushup/models": "^0.96.1",
"@code-pushup/nx-plugin": "^0.96.1",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to install it because ATM Nx plugins don't take import aliases in any way. This means our nx-plugin code is always 1 release behind the current PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant