Open
Conversation
Replace Radium array-merge style syntax with plain object spreads:
[frameStyle, !showX && styles.hidden]
→ showX ? frameStyle : {...frameStyle, ...styles.hidden}
Drop the Radium HoC wrapper; UnconnectedTeacherContentToggle is now
the bare class. All 13 existing unit tests pass unchanged.
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/V4tl5zTF/9-remove-radium-from-apps-src-code-studio-components-teachercontenttogglejs
Summary
radiumimport andRadium()HoC wrapper fromTeacherContentToggle.js[baseStyle, condStyle]) with plain object spread:showX ? baseStyle : {...baseStyle, ...hiddenStyle}UnconnectedTeacherContentToggleexport is now the bare class instead ofRadium(TeacherContentToggle)Where to verify
TeacherContentTogglerenders in the teacher panel on any level page. Log in as a teacher and visit any student level, then toggle View as → Student to exercise the locked/hidden lesson overlay behavior:/s/csp1-2023/lessons/1/levels/1(or any unit with a lockable lesson)Check that:
Test plan
🤖 Generated with Claude Code