temporarily run all ui/eyes tests using local chromedriver in ci#72203
Draft
davidsbailey wants to merge 3 commits intostagingfrom
Draft
temporarily run all ui/eyes tests using local chromedriver in ci#72203davidsbailey wants to merge 3 commits intostagingfrom
davidsbailey wants to merge 3 commits intostagingfrom
Conversation
Add waits and use jQuery click for steps that were racing on local
chromedriver:
- version_history: wait for #resetButton before second
add-another-version
- authored_hints, contextual_hints: swap Selenium native click for
jQuery click on #lightbulb. When the hint content is showing in
.csf-top-instructions, Selenium's interactability check fails on
the lightbulb even though jQuery :visible reports it visible.
Clicking via $('#lightbulb')[0].click() still fires React's
delegated click handler (on .prompt-icon-cell, the parent) and
avoids the Selenium check.
- applab clipping: wait for #designModeViz.clip-content instead of
asserting the class synchronously after switching to design mode
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.