test(connectors): add unit tests for Google Drive source connector#1985
Open
nuthalapativarun wants to merge 1 commit into
Open
test(connectors): add unit tests for Google Drive source connector#1985nuthalapativarun wants to merge 1 commit into
nuthalapativarun wants to merge 1 commit into
Conversation
Add unit tests for _parse_modified_time() and DriveFilePath helper classes that run without a live Google Drive service. Live tests are gated on the GOOGLE_DRIVE_CREDENTIALS env var and skipped when absent.
Contributor
Author
|
Hi team — just checking in on this PR. All CI checks are passing and it's ready to merge. Let me know if you'd like any changes! |
Contributor
Author
|
Gentle ping — happy to address any feedback. |
Contributor
Author
|
Friendly bump — CI is green and this is still awaiting review whenever someone has time. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_parse_modified_time(): valid UTC string,None, empty string, offset-aware ISO timestamp, and millisecond-precision timestampsDriveFilePath:resolve()returns file ID, path preservation,_with_path()preserves file ID and type, equality by pathtest_turbopuffer_target.py— no live service required, live tests gated onGOOGLE_DRIVE_CREDENTIALSenv varTest plan
uv run pytest python/tests/connectors/test_google_drive_source.py -v— 11 passeduv tool run ruff format --check python/tests/connectors/test_google_drive_source.py— already formatteduv tool run ruff check python/tests/connectors/test_google_drive_source.py— all checks passed