[stack 16/20] spec(gazprea): remove struct field forbidden by struct's own rule - #127
Closed
Sir-NoChill wants to merge 1 commit into
Closed
[stack 16/20] spec(gazprea): remove struct field forbidden by struct's own rule#127Sir-NoChill wants to merge 1 commit into
Sir-NoChill wants to merge 1 commit into
Conversation
Sir-NoChill
force-pushed
the
fix/slice-bounds
branch
from
August 15, 2026 16:33
0382f65 to
035b73c
Compare
Sir-NoChill
force-pushed
the
fix/struct-nesting
branch
from
August 15, 2026 16:33
5bca7dc to
7b5126c
Compare
The Another example nested a struct-typed field two paragraphs after the rule banning struct fields, and used the undefined sized-string syntax string[256] (strings have no size specifier per string.rst); the field list and its prose now agree with both rules. Also corrects the 's' vs 's1' type-name slip in the same sentence. Assisted-by: Agent (claude) <ai@blobfish.icu>
Sir-NoChill
force-pushed
the
fix/slice-bounds
branch
from
August 21, 2026 19:00
035b73c to
c8be9f9
Compare
Sir-NoChill
force-pushed
the
fix/struct-nesting
branch
from
August 21, 2026 19:00
7b5126c to
a680b7a
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Origin:
spec-patches/05-fix-struct-nesting.patch(backlog audit).What
gazprea/spec/types/struct.rst— theAnotherexample in Declaration violated two rules stated a paragraph earlier and elsewhere in the spec:tuple, anotherstructandstreamsmay be stored within a struct", yetAnothercontained ans1 struct_field. Removed.string[N]is not a valid type spelling: pertypes/string.rst, strings have no size specifier. Changedstring[256] str→character[256] str.shas three fields" — should bes1. Corrected.The prose that enumerated
Another's fields is updated to match (four → three named fields;struct_fielddropped).Audit — ambiguities for reviewer attention
stringvscharacter[N]: patch preferscharacter[256]to model a fixed-length string-like field. If Gazprea does support sized strings elsewhere (or if the intent was a variable-length string with a bounding hint), the correct fix is different — eitherstring(unsized) or a normative addition to the string chapter. Confirm which is intended.Anotherexample suggested), the fix is the other direction — keeps1 struct_fieldand amendtypes.rstand the chapter opening. Reviewer's call which is normative.t1andt2, not the removedstruct_field.Stack
Depends on #126; part of stack #121.
🤖 Backlog patch applied by Claude Code