Skip to content

Fix missing cloud config update in new network tests#63

Merged
neddp merged 6 commits into
cloudfoundry:masterfrom
neddp:integrate_new_bats_tests
Jul 3, 2026
Merged

Fix missing cloud config update in new network tests#63
neddp merged 6 commits into
cloudfoundry:masterfrom
neddp:integrate_new_bats_tests

Conversation

@neddp

@neddp neddp commented Jul 2, 2026

Copy link
Copy Markdown
Member

When these tests run in isolation (e.g. with tag filtering), the director has no cloud config and all deployments fail with "Required property 'networks' was not specified".

The refactor in PR cloudfoundry#54 replaced @requirements.requirement(@deployment, @SPEC)
with direct with_deployment + bosh deploy calls, silently dropping the
update_cloud_config step. When these tests run in isolation (e.g. with tag
filtering), the director has no cloud config and all deployments fail with
"Required property 'networks' was not specified".
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

This PR adds the base64 gem to the Gemfile and modifies system spec files. Two contexts in ipv6_network_configuration_spec.rb and one context in network_configuration_spec.rb now call @requirements.update_cloud_config(@SPEC) before deployment. Additionally, the inter-instance IPv6 ping command was changed from ping6 to sudo ping6 while keeping the same result-parsing logic.

Changes

File Change Summary
Gemfile Added gem 'base64' dependency
spec/system/ipv6_network_configuration_spec.rb Added update_cloud_config(@SPEC) calls in two setup contexts; changed ping6 to sudo ping6
spec/system/network_configuration_spec.rb Added update_cloud_config(@SPEC) call before capturing deployment in nic_groups context

Suggested reviewers: KauzClay, aramprice

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately summarizes the main fix: restoring the missing cloud config update in the new network tests.
Description check ✅ Passed The description matches the reported failure mode and is directly related to the test isolation/cloud config fix.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@neddp neddp marked this pull request as ready for review July 3, 2026 04:01
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 3, 2026
@github-project-automation github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Jul 3, 2026
@neddp neddp requested a review from Copilot July 3, 2026 04:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the system network configuration specs resilient when run in isolation by ensuring the BOSH director has an up-to-date cloud config before attempting deployments (preventing failures like “Required property 'networks' was not specified”).

Changes:

  • Call @requirements.update_cloud_config(@spec) before bosh deploy in network-related specs that deploy directly.
  • Run ping6 via sudo during IPv6 inter-instance connectivity verification.
  • Add base64 to the Gemfile.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
spec/system/network_configuration_spec.rb Updates cloud config before deploying in the nic_groups context to avoid missing cloud config when tests run alone.
spec/system/ipv6_network_configuration_spec.rb Updates cloud config before deploying in IPv6 contexts; uses sudo ping6 for connectivity checks.
Gemfile Adds the base64 gem dependency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Gemfile
@neddp neddp merged commit 31057b3 into cloudfoundry:master Jul 3, 2026
6 checks passed
@neddp neddp deleted the integrate_new_bats_tests branch July 3, 2026 11:24
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants