Fix missing cloud config update in new network tests#63
Conversation
The refactor in PR cloudfoundry#54 replaced @requirements.requirement(@deployment, @SPEC) with direct with_deployment + bosh deploy calls, silently dropping the update_cloud_config step. When these tests run in isolation (e.g. with tag filtering), the director has no cloud config and all deployments fail with "Required property 'networks' was not specified".
WalkthroughThis PR adds the Changes
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR makes the system network configuration specs resilient when run in isolation by ensuring the BOSH director has an up-to-date cloud config before attempting deployments (preventing failures like “Required property 'networks' was not specified”).
Changes:
- Call
@requirements.update_cloud_config(@spec)beforebosh deployin network-related specs that deploy directly. - Run
ping6viasudoduring IPv6 inter-instance connectivity verification. - Add
base64to the Gemfile.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spec/system/network_configuration_spec.rb | Updates cloud config before deploying in the nic_groups context to avoid missing cloud config when tests run alone. |
| spec/system/ipv6_network_configuration_spec.rb | Updates cloud config before deploying in IPv6 contexts; uses sudo ping6 for connectivity checks. |
| Gemfile | Adds the base64 gem dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
When these tests run in isolation (e.g. with tag filtering), the director has no cloud config and all deployments fail with "Required property 'networks' was not specified".