CI: cleanup run-bats task

[aramprice]

• remove image_resource
  • this pointed at an outdated location; should be provided by the invoker
• shellcheck fixes
• add action to run bats own specs

[coderabbitai]

Warning

Review limit reached

@aramprice, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 25 minutes and 24 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4293af7a-7f09-47a3-abd8-b1e0f072ca7c

📥 Commits

Reviewing files that changed from the base of the PR and between d86276c and 0c3e14b.

📒 Files selected for processing (5)

• .github/workflows/ruby.yml
• Gemfile
• ci/tasks/run-bats.sh
• ci/tasks/run-bats.yml
• spec/bat/bosh_helper_spec.rb

Walkthrough

This PR updates the BATS CI task with two changes: the shell script now runs in stricter mode (set -euo pipefail) and refactors environment variable assignments to use realpath followed by explicit export statements. The CI configuration YAML now declares platform: linux and removes the previous image_resource block referencing bosh/integration, while preserving inputs and run script path.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'CI: cleanup run-bats task' accurately describes the main change: removing outdated configuration and applying fixes to the run-bats task.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The pull request description accurately describes the changes made: removal of outdated image_resource, shellcheck fixes, and improved shell script strictness.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch task-cleanup

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR cleans up the Concourse run-bats task by removing the hard-coded image_resource (so the invoker provides the image) and applying ShellCheck-motivated hardening/quoting improvements to the task script.

Changes:

• Remove image_resource from ci/tasks/run-bats.yml so the pipeline/task step supplies the container image.
• Harden ci/tasks/run-bats.sh with set -euo pipefail and improved quoting/export patterns.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
ci/tasks/run-bats.yml	Removes embedded image_resource so the calling pipeline provides the image.
ci/tasks/run-bats.sh	Adds stricter bash settings and adjusts variable handling/quoting for running the BAT rspec suite.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ci/tasks/run-bats.sh`:
- Line 6: The assignment to BAT_BOSH_CLI uses which and realpath; replace the
use of which with the POSIX-standard command -v to locate the bosh binary (i.e.,
run realpath on the output of command -v bosh) and add a simple existence check
so an empty result doesn’t get passed to realpath; update the BAT_BOSH_CLI
assignment and ensure you handle the case where command -v returns nothing by
logging or exiting accordingly.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d8090b4b-0227-49cc-8d04-698ea5f616c2

📥 Commits

Reviewing files that changed from the base of the PR and between 857c0ca and d86276c.

📒 Files selected for processing (2)

• ci/tasks/run-bats.sh
• ci/tasks/run-bats.yml

💤 Files with no reviewable changes (1)

• ci/tasks/run-bats.yml

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.