feat: subtle appearance for banner#533
Conversation
commit: |
Docs PreviewCommit: |
|
/bonk review |
There was a problem hiding this comment.
LGTM! Well-implemented non-breaking change that follows all component conventions.
Summary:
- ✅ New
appearanceprop withbordered(default) andsubtleoptions - ✅ New
secondaryvariant for neutral messages - ✅ Proper subtle background styles per variant via
KUMO_BANNER_SUBTLE_VARIANT_STYLES - ✅ Title-less structured Banner alignment fix (
!title && "pt-px") - ✅ Tests cover default appearance, subtle appearance, secondary variant, and prop forwarding
- ✅ Demos and documentation updated appropriately
- ✅ Changeset included for minor version bump
Visual regression note: The 9 changed screenshots appear to be unrelated to this PR (Button, Dialog, Select components). These are likely baseline drift or timing-related flakes.
| <div | ||
| className={cn( | ||
| "flex min-w-0 flex-1 items-center justify-between gap-3", | ||
| !title && "pt-px", |
There was a problem hiding this comment.
Nice alignment fix for the title-less structured Banner case with icon.
| }, | ||
| } as const; | ||
|
|
||
| const KUMO_BANNER_SUBTLE_VARIANT_STYLES = { |
There was a problem hiding this comment.
Good approach using a separate styles object for subtle appearance overrides rather than overcomplicating the main variants object.
| @@ -0,0 +1,45 @@ | |||
| import { describe, expect, it } from "vitest"; | |||
There was a problem hiding this comment.
Good test coverage for the new functionality. Tests are focused on the variant/appearance logic and prop forwarding.
|
Approved! Review Summary: This PR is a well-implemented, non-breaking addition to the Banner component:
The changes follow all component conventions (variant objects, |



























Summary
Adds a non-breaking
appearanceprop toBannerwith a newsubtleoption, plus a newsecondaryvariant for neutral messages.Also updates the Banner docs demos and HomeGrid usage to show the subtle appearance, and fixes title-less structured Banner alignment when an icon is present.