log executeCode return values - #300
Open
maxwellpeterson wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
kernel
Preview:
|
maxwellpeterson
marked this pull request as ready for review
August 21, 2026 19:28
ndisidore
reviewed
Aug 21, 2026
| } | ||
| await agent(self, env, this.ctx); | ||
| let result = await agent(self, env, this.ctx); | ||
| if (result !== undefined) console.log(result); |
Contributor
There was a problem hiding this comment.
If the agent is doing something sensitive like fetching the body of a secure document, won't this mean its captured in chat output? There's no way to opt in/out?
Member
Author
There was a problem hiding this comment.
I'm not sure why the agent would return a value it didn't want to appear in the tool output. I added a line to the tool description to make this behavior more explicit, but I don't think we need an opt in/out mechanism here.
maxwellpeterson
force-pushed
the
mpeterson/execute-code-return-values
branch
from
August 21, 2026 19:52
bf9da6a to
60cdb65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kimi likes to return values when using the
executeCodetool instead of logging them. Return values are currently discarded, which causes confusion. We can automatically log them instead.This is probably a better alternative to #299
Fixes #209