Skip to content

salvage valid settings instead of resetting store on parse failure#1631

Merged
cjpais merged 1 commit into
mainfrom
settings-robustness
Jul 8, 2026
Merged

salvage valid settings instead of resetting store on parse failure#1631
cjpais merged 1 commit into
mainfrom
settings-robustness

Conversation

@cjpais

@cjpais cjpais commented Jul 8, 2026

Copy link
Copy Markdown
Owner

One bad value in the settings store used to fail the whole parse and the loader reset everything to defaults. Now a salvage pass keeps every valid field and defaults only the broken ones.

Fixes #1619

@cjpais cjpais merged commit cd040d9 into main Jul 8, 2026
4 checks passed
hailuwaycom-sketch added a commit to hailuwaycom-sketch/Handy that referenced this pull request Jul 11, 2026
Integra los fixes de upstream v0.9.1 preservando todo el trabajo VozImperio.

Resolucion de conflictos:
- tauri.conf.json: identidad VozImperio (productName/identifier) + version 0.9.1.
- theme.css: se adopta el mecanismo light/dark/system de upstream pero ambos
  pares apuntan a la paleta imperial oscura (marca dark forzada). ThemeSelector
  oculto en AboutSettings (plomeria intacta).
- settings.rs: se adopta el salvage_settings de upstream (cjpais#1631) y se descarta
  nuestro repair_settings_value paralelo; se preservan defaults VozImperio
  (audio_feedback=true, selected_language=es, mute_while_recording=true, etc.)
  y campos propios (noise_suppression, text_replacement_rules, pause_media).
- recorder.rs: coexisten noise_suppressor init (nuestro) y frame_resampler.reset()
  de upstream (fix crosstalk cjpais#1344).
- actions.rs: la rama is_replace_selection (AI Replace) convive con el wrapper
  complete_unless_cancelled de upstream (cancelar post-proceso colgado cjpais#1614).
- bindings.ts: se regenerara desde el Rust en el proximo build debug.

Fixes de upstream incorporados sin colision: reset resampler, throttle mic IPC,
poisoned mutex on quit, faster mic init, unicode paths, VS redist, paste delay,
prompt-injection defense, transcribe-cpp 0.1.2, i18n (nl/ne + claves nuevas).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Invalid stored settings can reset the entire configuration to defaults

1 participant