Skip to content

part: release the previous root from cached transactions - #209

Merged
joamaki merged 1 commit into
mainfrom
pr/joamaki/part-drop-oldroot
Oct 13, 2026
Merged

joamaki merged 1 commit into
mainfrom
pr/joamaki/part-drop-oldroot

Conversation

@joamaki

@joamaki joamaki commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

The previous root is only needed by optional invariant validation. Capture it only when validation is enabled and clear it after Notify finishes its checks, so cached transactions do not retain it in normal operation. Commit keeps it available for Commit followed by Notify.

AIL:3

The previous root is only needed by optional invariant validation.
Capture it only when validation is enabled and clear it after Notify
finishes its checks, so cached transactions do not retain it in normal
operation. Commit keeps it available for Commit followed by Notify.

AIL:3
Signed-off-by: Jussi Maki <jussi@isovalent.com>
@joamaki
joamaki requested a review from a team as a code owner October 12, 2026 11:59
@joamaki
joamaki requested review from derailed and removed request for a team October 12, 2026 11:59
@github-actions

Copy link
Copy Markdown
$ make
go build ./...
go: downloading github.com/cilium/hive v1.0.4
go: downloading golang.org/x/time v0.15.0
go: downloading github.com/spf13/cobra v1.10.2
go: downloading github.com/spf13/pflag v1.0.10
go: downloading go.yaml.in/yaml/v3 v3.0.4
go: downloading github.com/cilium/stream v0.0.1
go: downloading github.com/liggitt/tabwriter v0.0.0-20181228230101-89fcab3d43de
go: downloading github.com/spf13/viper v1.18.2
go: downloading go.uber.org/dig v1.17.1
go: downloading golang.org/x/term v0.16.0
go: downloading github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc
go: downloading github.com/mitchellh/mapstructure v1.5.0
go: downloading golang.org/x/sys v0.17.0
go: downloading golang.org/x/tools v0.17.0
go: downloading github.com/fsnotify/fsnotify v1.7.0
go: downloading github.com/sagikazarmark/slog-shim v0.1.0
go: downloading github.com/spf13/afero v1.11.0
go: downloading github.com/spf13/cast v1.6.0
go: downloading github.com/subosito/gotenv v1.6.0
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading gopkg.in/ini.v1 v1.67.0
go: downloading github.com/magiconair/properties v1.8.7
go: downloading github.com/pelletier/go-toml/v2 v2.1.0
go: downloading gopkg.in/yaml.v3 v3.0.1
go: downloading golang.org/x/text v0.14.0
STATEDB_VALIDATE=1 go test ./... -cover -vet=all -test.count 1
go: downloading github.com/stretchr/testify v1.11.1
go: downloading go.uber.org/goleak v1.3.0
go: downloading golang.org/x/exp v0.0.0-20240119083558-1b970713d09a
go: downloading github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2
ok  	github.com/cilium/statedb	314.902s	coverage: 79.6% of statements
ok  	github.com/cilium/statedb/index	0.006s	coverage: 48.6% of statements
ok  	github.com/cilium/statedb/internal	0.042s	coverage: 54.1% of statements
ok  	github.com/cilium/statedb/lpm	4.097s	coverage: 76.4% of statements
ok  	github.com/cilium/statedb/part	77.423s	coverage: 86.6% of statements
ok  	github.com/cilium/statedb/reconciler	0.265s	coverage: 93.3% of statements
	github.com/cilium/statedb/reconciler/benchmark		coverage: 0.0% of statements
	github.com/cilium/statedb/reconciler/example		coverage: 0.0% of statements
go test -race ./... -test.count 1
ok  	github.com/cilium/statedb	39.574s
ok  	github.com/cilium/statedb/index	1.015s
ok  	github.com/cilium/statedb/internal	1.031s
ok  	github.com/cilium/statedb/lpm	2.826s
ok  	github.com/cilium/statedb/part	37.498s
ok  	github.com/cilium/statedb/reconciler	1.364s
?   	github.com/cilium/statedb/reconciler/benchmark	[no test files]
?   	github.com/cilium/statedb/reconciler/example	[no test files]
go test ./... -bench . -benchmem -test.run xxx
goos: linux
goarch: amd64
pkg: github.com/cilium/statedb
cpu: AMD EPYC 7763 64-Core Processor                
BenchmarkDB_WriteTxn_1-4                      	  883965	      1206 ns/op	    829334 objects/sec	     632 B/op	      12 allocs/op
BenchmarkDB_WriteTxn_10-4                     	 2244290	       532.3 ns/op	   1878681 objects/sec	     349 B/op	       5 allocs/op
BenchmarkDB_WriteTxn_100-4                    	 2685433	       448.1 ns/op	   2231475 objects/sec	     317 B/op	       5 allocs/op
BenchmarkDB_WriteTxn_1000-4                   	 2316382	       513.0 ns/op	   1949140 objects/sec	     318 B/op	       5 allocs/op
BenchmarkDB_WriteTxn_100_SecondaryIndex-4     	 1599100	       749.2 ns/op	   1334805 objects/sec	     419 B/op	       7 allocs/op
BenchmarkDB_WriteTxn_CommitOnly_100Tables-4   	 1518129	       799.0 ns/op	    1088 B/op	       3 allocs/op
BenchmarkDB_WriteTxn_CommitOnly_1Table-4      	 2112687	       565.3 ns/op	     200 B/op	       3 allocs/op
BenchmarkDB_NewWriteTxn-4                     	 2309149	       517.8 ns/op	     200 B/op	       3 allocs/op
BenchmarkDB_WriteTxnCommit100-4               	 1539427	       780.6 ns/op	    1072 B/op	       3 allocs/op
BenchmarkDB_NewReadTxn-4                      	641274295	         1.879 ns/op	       0 B/op	       0 allocs/op
BenchmarkDB_Modify-4                          	    2218	    533581 ns/op	   1874129 objects/sec	  342484 B/op	    6072 allocs/op
BenchmarkDB_GetInsert-4                       	    1980	    602134 ns/op	   1660759 objects/sec	  326482 B/op	    6072 allocs/op
BenchmarkDB_ListInsert-4                      	    1521	    787589 ns/op	   1269698 objects/sec	  486515 B/op	   11072 allocs/op
BenchmarkDB_RandomInsert-4                    	    2409	    497590 ns/op	   2009685 objects/sec	  318477 B/op	    5072 allocs/op
BenchmarkDB_RandomReplace-4                   	    1233	    962295 ns/op	   1039182 objects/sec	  432299 B/op	    8088 allocs/op
BenchmarkDB_SequentialInsert-4                	    2302	    486288 ns/op	   2056396 objects/sec	  318477 B/op	    5072 allocs/op
BenchmarkDB_SequentialInsert_Prefix-4         	     542	   2200315 ns/op	    454480 objects/sec	 2794463 B/op	   41797 allocs/op
BenchmarkDB_Changes_Baseline-4                	    2076	    573054 ns/op	   1745037 objects/sec	  388220 B/op	    6162 allocs/op
BenchmarkDB_Changes-4                         	    1072	   1094526 ns/op	    913638 objects/sec	  604015 B/op	    9323 allocs/op
BenchmarkDB_RandomLookup-4                    	   26566	     44778 ns/op	  22332539 objects/sec	       0 B/op	       0 allocs/op
BenchmarkDB_SequentialLookup-4                	   33024	     36450 ns/op	  27434803 objects/sec	       0 B/op	       0 allocs/op
BenchmarkDB_Prefix_SecondaryIndex-4           	    8419	    131859 ns/op	   7583865 objects/sec	  108952 B/op	      26 allocs/op
BenchmarkDB_LowerBound_SecondaryIndex-4       	    8144	    135083 ns/op	   7402875 objects/sec	  109240 B/op	      28 allocs/op
BenchmarkDB_FullIteration_All-4               	    1234	   1094060 ns/op	  91402638 objects/sec	     104 B/op	       4 allocs/op
BenchmarkDB_FullIteration_Prefix-4            	     967	   1237638 ns/op	  80799096 objects/sec	     136 B/op	       5 allocs/op
BenchmarkDB_FullIteration_Get-4               	     270	   4478881 ns/op	  22327005 objects/sec	       0 B/op	       0 allocs/op
BenchmarkDB_FullIteration_Get_Secondary-4     	     100	  10440705 ns/op	   9577897 objects/sec	       0 B/op	       0 allocs/op
BenchmarkDB_FullIteration_ReadTxnGet-4        	     267	   4640297 ns/op	  21550345 objects/sec	       0 B/op	       0 allocs/op
BenchmarkDB_PropagationDelay-4                	  963304	      1238 ns/op	        10.00 50th_µs	        13.00 90th_µs	        39.00 99th_µs	     755 B/op	      12 allocs/op
BenchmarkDB_WriteTxn_1_DefaultMetrics-4       	  840900	      1274 ns/op	     632 B/op	      12 allocs/op
BenchmarkDB_WriteTxn_1_ExpVarMetrics-4        	  749836	      1631 ns/op	     656 B/op	      15 allocs/op
BenchmarkDB_WriteTxn_100_LPMIndex-4           	  571429	      2255 ns/op	    443397 objects/sec	    1571 B/op	      35 allocs/op
BenchmarkDB_WriteTxn_1_LPMIndex-4             	  168358	     12679 ns/op	     78873 objects/sec	   13916 B/op	      65 allocs/op
BenchmarkDB_LPMIndex_Get-4                    	     442	   2674370 ns/op	   3739199 objects/sec	       0 B/op	       0 allocs/op
BenchmarkWatchSet_4-4                         	 2347098	       502.3 ns/op	     296 B/op	       4 allocs/op
BenchmarkWatchSet_16-4                        	  778771	      1539 ns/op	    1096 B/op	       5 allocs/op
BenchmarkWatchSet_128-4                       	   89310	     13353 ns/op	    8904 B/op	       5 allocs/op
BenchmarkWatchSet_1024-4                      	    8227	    133133 ns/op	   73744 B/op	       5 allocs/op
PASS
ok  	github.com/cilium/statedb	50.000s
PASS
ok  	github.com/cilium/statedb/index	0.004s
goos: linux
goarch: amd64
pkg: github.com/cilium/statedb/internal
cpu: AMD EPYC 7763 64-Core Processor                
Benchmark_SortableMutex-4   	 6331108	       189.0 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	github.com/cilium/statedb/internal	1.201s
goos: linux
goarch: amd64
pkg: github.com/cilium/statedb/lpm
cpu: AMD EPYC 7763 64-Core Processor                
Benchmark_txn_insert/batchSize=1-4         	    1867	    635733 ns/op	   1572987 objects/sec	  822407 B/op	   13975 allocs/op
Benchmark_txn_insert/batchSize=10-4        	    3211	    370051 ns/op	   2702327 objects/sec	  369194 B/op	    6668 allocs/op
Benchmark_txn_insert/batchSize=100-4       	    3531	    346657 ns/op	   2884697 objects/sec	  329613 B/op	    6027 allocs/op
Benchmark_txn_delete/batchSize=1-4         	    1594	    801398 ns/op	   1247819 objects/sec	 1270474 B/op	   13976 allocs/op
Benchmark_txn_delete/batchSize=10-4        	    3301	    364805 ns/op	   2741190 objects/sec	  356418 B/op	    5769 allocs/op
Benchmark_txn_delete/batchSize=100-4       	    3680	    325474 ns/op	   3072443 objects/sec	  270754 B/op	    5038 allocs/op
Benchmark_LPM_Lookup-4                     	    9220	    127819 ns/op	   7823580 objects/sec	       0 B/op	       0 allocs/op
Benchmark_LPM_All-4                        	  135032	      8956 ns/op	 111651090 objects/sec	      32 B/op	       1 allocs/op
Benchmark_LPM_Prefix-4                     	  133635	      9148 ns/op	 109312323 objects/sec	      32 B/op	       1 allocs/op
Benchmark_LPM_LowerBound-4                 	  240232	      4840 ns/op	 103310720 objects/sec	     288 B/op	       2 allocs/op
PASS
ok  	github.com/cilium/statedb/lpm	12.064s
goos: linux
goarch: amd64
pkg: github.com/cilium/statedb/part
cpu: AMD EPYC 7763 64-Core Processor                
Benchmark_Set_Singleton_Create-4              	21833476	        54.65 ns/op	      24 B/op	       1 allocs/op
Benchmark_Set_Singleton_Has-4                 	100000000	        11.23 ns/op	       0 B/op	       0 allocs/op
Benchmark_StringMap_Txn_Insert-4              	    8335	    142981 ns/op	   6993931 items/sec	   98250 B/op	    1306 allocs/op
Benchmark_Uint64Map_Random-4                  	    1983	    629120 ns/op	   1589522 items/sec	 1322423 B/op	    6031 allocs/op
Benchmark_Uint64Map_Sequential-4              	    1891	    600358 ns/op	   1665674 items/sec	 1703089 B/op	    5753 allocs/op
Benchmark_Uint64Map_Sequential_Insert-4       	    2206	    564196 ns/op	   1772433 items/sec	 1695085 B/op	    4752 allocs/op
Benchmark_Uint64Map_Sequential_Txn_Insert-4   	   10000	    119222 ns/op	   8387706 items/sec	   90464 B/op	    2031 allocs/op
Benchmark_Uint64Map_Random_Insert-4           	    2073	    599440 ns/op	   1668224 items/sec	 1313132 B/op	    5040 allocs/op
Benchmark_Uint64Map_Random_Txn_Insert-4       	    6601	    184083 ns/op	   5432324 items/sec	  117692 B/op	    2420 allocs/op
Benchmark_Insert_RootOnlyWatch-4              	   10000	    114714 ns/op	   8717326 objects/sec	   75552 B/op	    2036 allocs/op
Benchmark_Insert-4                            	   10000	    113261 ns/op	   8829173 objects/sec	   76096 B/op	    2047 allocs/op
Benchmark_WatchReplace-4                      	   10000	    100423 ns/op	   9957833 objects/sec	   57305 B/op	    1006 allocs/op
Benchmark_Modify-4                            	   12384	     96979 ns/op	  10311508 objects/sec	   58056 B/op	    1007 allocs/op
Benchmark_GetInsert-4                         	    9760	    116955 ns/op	   8550304 objects/sec	   58056 B/op	    1007 allocs/op
Benchmark_Replace-4                           	32925837	        36.30 ns/op	  27548000 objects/sec	       0 B/op	       0 allocs/op
Benchmark_Replace_RootOnlyWatch-4             	32555736	        36.49 ns/op	  27406846 objects/sec	       0 B/op	       0 allocs/op
Benchmark_txn_1-4                             	 7740993	       152.0 ns/op	   6577830 objects/sec	      64 B/op	       3 allocs/op
Benchmark_txn_10-4                            	10280150	       114.6 ns/op	   8727146 objects/sec	      76 B/op	       2 allocs/op
Benchmark_txn_100-4                           	11673829	       102.5 ns/op	   9753947 objects/sec	      67 B/op	       2 allocs/op
Benchmark_txn_1000-4                          	10191805	       117.0 ns/op	   8546593 objects/sec	      65 B/op	       2 allocs/op
Benchmark_txn_delete_1-4                      	 5313962	       229.2 ns/op	   4363334 objects/sec	     632 B/op	       3 allocs/op
Benchmark_txn_delete_10-4                     	11373182	       104.1 ns/op	   9604175 objects/sec	     103 B/op	       1 allocs/op
Benchmark_txn_delete_100-4                    	14114785	        84.18 ns/op	  11878922 objects/sec	      35 B/op	       1 allocs/op
Benchmark_txn_delete_1000-4                   	14512000	        81.71 ns/op	  12237861 objects/sec	      28 B/op	       1 allocs/op
Benchmark_Get-4                               	   61564	     19612 ns/op	  50988388 objects/sec	       0 B/op	       0 allocs/op
Benchmark_GetWatch-4                          	   47416	     25176 ns/op	  39720570 objects/sec	       0 B/op	       0 allocs/op
Benchmark_All-4                               	  118141	     10172 ns/op	  98313766 objects/sec	       0 B/op	       0 allocs/op
Benchmark_Iterator_All-4                      	  124860	     10423 ns/op	  95937903 objects/sec	       0 B/op	       0 allocs/op
Benchmark_Iterator_Next-4                     	  159319	      7541 ns/op	 132615164 objects/sec	     896 B/op	       1 allocs/op
Benchmark_LowerBound-4                        	   10000	    101490 ns/op	   9853155 objects/sec	  104000 B/op	    2000 allocs/op
Benchmark_LowerBound_Random-4                 	    7713	    152628 ns/op	   6551891 objects/sec	   96384 B/op	    1002 allocs/op
Benchmark_Hashmap_Insert-4                    	   14722	     81348 ns/op	  12292924 objects/sec	   74264 B/op	      20 allocs/op
Benchmark_Hashmap_Get_Uint64-4                	  134476	      8919 ns/op	 112119123 objects/sec	       0 B/op	       0 allocs/op
Benchmark_Hashmap_Get_Bytes-4                 	  109366	     10946 ns/op	  91358238 objects/sec	       0 B/op	       0 allocs/op
Benchmark_Delete_Random-4                     	      78	  15379651 ns/op	   6502098 objects/sec	 2539539 B/op	  102756 allocs/op
Benchmark_find16-4                            	213258066	         5.619 ns/op	       0 B/op	       0 allocs/op
Benchmark_findIndex16-4                       	80224537	        13.43 ns/op	       0 B/op	       0 allocs/op
Benchmark_find64-4                            	295682359	         4.058 ns/op	       0 B/op	       0 allocs/op
Benchmark_findIndex64_hit-4                   	295491594	         4.059 ns/op	       0 B/op	       0 allocs/op
Benchmark_findIndex64_miss-4                  	295448174	         4.059 ns/op	       0 B/op	       0 allocs/op
Benchmark_find4-4                             	421962510	         2.839 ns/op	       0 B/op	       0 allocs/op
Benchmark_findIndex4-4                        	320490265	         3.751 ns/op	       0 B/op	       0 allocs/op
BenchmarkSmallWriteTxn/updates_1-4            	  440239	      2628 ns/op	    3529 B/op	       4 allocs/op
BenchmarkSmallWriteTxn/updates_2-4            	  307142	      3625 ns/op	    4742 B/op	       6 allocs/op
BenchmarkSmallWriteTxn/updates_4-4            	  203035	      5798 ns/op	    7155 B/op	      11 allocs/op
BenchmarkSmallWriteTxn/updates_8-4            	  122294	      9909 ns/op	   11927 B/op	      20 allocs/op
BenchmarkSmallWriteTxn/updates_16-4           	   66536	     17933 ns/op	   21289 B/op	      38 allocs/op
BenchmarkAtomicWatchPointerFirstChannel-4     	20409378	        58.82 ns/op	     120 B/op	       2 allocs/op
BenchmarkAtomicWatchPointerChannel-4          	548159893	         2.183 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	github.com/cilium/statedb/part	59.704s
PASS
ok  	github.com/cilium/statedb/reconciler	0.005s
?   	github.com/cilium/statedb/reconciler/benchmark	[no test files]
?   	github.com/cilium/statedb/reconciler/example	[no test files]
go run ./reconciler/benchmark -quiet
1000000 objects reconciled in 1.62 seconds (batch size 1000)
Throughput 618011.07 objects per second
506MB total allocated, 5007241 in-use objects, 231MB bytes in use

@joamaki
joamaki merged commit 4cc286a into main Oct 13, 2026
1 check passed
@joamaki
joamaki deleted the pr/joamaki/part-drop-oldroot branch October 13, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants