Fix contributor-ladder PR template links using @me - #440
Open
magic-peach wants to merge 1 commit into
Open
Conversation
joestringer
enabled auto-merge (rebase)
September 9, 2026 19:12
Member
|
If we can, we should probably avoid the |
Links built with author:me and reviewed-by:me resolve relative to whoever clicks them, so they show the reviewer's own contributions instead of the applicant's once someone else opens the PR. Replaced the me alias with a REPLACE-ME placeholder the contributor swaps in first. Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
auto-merge was automatically disabled
September 10, 2026 03:45
Head branch was pushed to by a user without write access
magic-peach
force-pushed
the
fix/pr-template-me-links
branch
from
September 10, 2026 03:45
87940be to
42a8c3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This repo's only PR template is the contributor-ladder one, which does not fit a fix to the template itself, so using a plain description here instead of forcing that template's fields.
Fixes #309: the contributor-ladder PR template's "your PRs/issues" links use
author:@meandreviewed-by:@me, which GitHub resolves relative to whoever clicks the link. That works for the applicant while drafting the PR, but once a reviewer clicks the same link later, it shows the reviewer's own issues and PRs instead of the applicant's.What changed
Replaced
@mewith aREPLACE-MEplaceholder in the three search links, plus a one-line instruction telling the contributor to substitute their username before submitting, matching the fix the issue itself suggested.