This repository was archived by the owner on Dec 13, 2022. It is now read-only.
Update rails 7.0#147
Draft
tjoyal wants to merge 5 commits into
Draft
Conversation
tjoyal
commented
May 3, 2022
| <div class="Polaris-FormLayout"> | ||
| <%= f.polaris_select(:service_name, available_handlers.map { |handler| [handler.label, handler.to_s] }, { prompt: "Select an action" }, { data: { handler: true } }) %> | ||
|
|
||
| <%= f.fields_for :settings, f.object.settings do |ff| %> |
Collaborator
Author
There was a problem hiding this comment.
Other than guessing, I couldn't explain with a reproductible fact why this used to work in the first place and what made rails 7.0 upgrade break it.
It shouldn't have worked before since f.object.settings is a Hash and should have been treated as options, not as a record object....
tjoyal
commented
May 3, 2022
| git_source(:github) { |repo| "https://github.com/#{repo}.git" } | ||
|
|
||
| # Bundle edge Rails instead: gem 'rails', github: 'rails/rails', branch: 'main' | ||
| gem 'rails', '~> 6.1' |
Collaborator
Author
There was a problem hiding this comment.
tjoyal
commented
May 3, 2022
| gem 'web-console', '>= 3.3.0' | ||
| gem 'listen', '~> 3.2' | ||
| # Spring speeds up development by keeping your application running in the background. Read more: https://github.com/rails/spring | ||
| gem 'spring' |
Collaborator
Author
There was a problem hiding this comment.
tjoyal
commented
May 3, 2022
|
|
||
| # Use Active Storage variant | ||
| # gem 'image_processing', '~> 1.2' | ||
| gem 'sprockets-rails', :require => 'sprockets/railtie' |
Collaborator
Author
There was a problem hiding this comment.
https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#sprockets-is-now-an-optional-dependency
Kept as-is as part of the upgrade
tjoyal
commented
May 3, 2022
| shopify_identifier: @shopify_identifier, | ||
| hooklys_identifier: @hooklys_identifier, | ||
| timestamp: @details.first.timestamp.to_s(:db), | ||
| timestamp: @details.first.timestamp.to_fs(:db), |
Collaborator
Author
There was a problem hiding this comment.
DEPRECATION WARNING: Time#to_s(:db) is deprecated. Please use Time#to_fs(:db) instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://guides.rubyonrails.org/upgrading_ruby_on_rails.html