Skip to content

fix: set status to idle before finalization on "Nothing to do" path #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chodeus merged 2 commits into from
Apr 15, 2026
+29 −17
Merged

fix: set status to idle before finalization on "Nothing to do" path #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e5f83b
fix: set status to idle before finalization on "Nothing to do" path
claude Apr 15, 2026
87450e7
refactor: extract _handle_nothing_to_do to fix lint complexity
claude Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 29 additions & 17 deletions beats_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,6 +571,32 @@ def _finalize_scan(log_dir, corrupt_list_path, corrupt_details,
logger.info("Review with: cat %s", corrupt_list_path)


def _handle_nothing_to_do(log_dir, corrupt_list_path, output_folder,
all_files, total_library_size, mode,
lidarr_url, lidarr_api_key):
"""Fast path when every file has already been processed."""
logger.debug("Nothing to do.")
# Mark idle before finalization — Lidarr ID resolution can take minutes
if _webui_app_state is not None:
_webui_app_state.update(status="idle", scan_progress=None)
existing_details = _load_json(
os.path.join(log_dir, "corrupt_details.json"))
_finalize_scan(log_dir, corrupt_list_path, existing_details,
output_folder, {
"version": __version__,
"finished": time.strftime('%Y-%m-%d %H:%M:%S'),
"duration": "0s",
"library_files": len(all_files),
"library_size": total_library_size,
"library_size_human": format_size(total_library_size),
"files_checked": 0,
"corrupted": 0,
"corrupt_size": 0,
"corrupt_size_human": format_size(0),
"mode": mode,
}, lidarr_url, lidarr_api_key)


def _run_scan_inner(input_folder, output_folder, log_file, log_dir,
mode, workers, corrupt_list_path, min_age_minutes,
lidarr_url=None, lidarr_api_key=None):
Expand Down Expand Up @@ -602,23 +628,9 @@ def _run_scan_inner(input_folder, output_folder, log_file, log_dir,
if lidarr_url and lidarr_api_key else None)

if total == 0:
logger.debug("Nothing to do.")
existing_details = _load_json(
os.path.join(log_dir, "corrupt_details.json"))
_finalize_scan(log_dir, corrupt_list_path, existing_details,
output_folder, {
"version": __version__,
"finished": time.strftime('%Y-%m-%d %H:%M:%S'),
"duration": "0s",
"library_files": len(all_files),
"library_size": total_library_size,
"library_size_human": format_size(total_library_size),
"files_checked": 0,
"corrupted": 0,
"corrupt_size": 0,
"corrupt_size_human": format_size(0),
"mode": mode,
}, lidarr_url, lidarr_api_key)
_handle_nothing_to_do(log_dir, corrupt_list_path, output_folder,
all_files, total_library_size, mode,
lidarr_url, lidarr_api_key)
return 0

checked = 0
Expand Down
Loading