fix(responses): normalize schema-declared integer tool arguments - #807
Merged
Conversation
AmPlace
marked this pull request as ready for review
July 28, 2026 02:11
chenyme
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
60000.0and6e4to the integer spelling required by strict downstream tool decodersnumberfields, fractional values, and values outside the exact JSON integer rangeRoot cause
Grok Build can emit a decimal JSON spelling for a tool argument declared as
integer. For example, Codex declareswait_agent.timeout_msas an integer, but an upstream call may contain{"timeout_ms":60000.0}. Codex rejects that argument before tool execution and may repeatedly retry the same invalid call.The existing Responses compatibility layer restored tool names and namespaces but forwarded ordinary function arguments unchanged.
Impact
Codex-compatible clients can execute strict-schema tools through Grok2API without failing on integral float spellings. Schema traversal covers nested objects, arrays, composition keywords, nullable integer types, and local
$refdefinitions.Validation
go test ./internal/infra/provider/cligo test ./...git diff --check