Merged
Conversation
e952f82 to
8c7554d
Compare
Member
|
Thank you for this PR I will take a look |
Contributor
Author
|
Thanks! I will have to rebase first |
|
Thanks @avoidik, added it to our fork. |
This commit adds support for Helm v4 while maintaining backward compatibility with Helm v3. Helm v2 support has been dropped. Key changes: - Added dual Helm v3/v4 API support using wrapper pattern - Runtime version detection by reading plugin manifest format - Separate plugin manifests for Helm v3 and v4 - Install hook automatically copies correct manifest - Updated acceptance tests to test both Helm 3 and 4 - Bumped dependencies to latest versions (Go 1.25, Helm v3.19.4, Helm v4.0.4) - Added arm64/aarch64 architecture support - Updated GoReleaser configuration (fixed deprecation warning) - Removed all Helm v2 code and references
Contributor
Author
|
hello @nerdeveloper I have rebased my PR, now it's ready for review |
…m to start in acceptance test environment
Contributor
Author
|
By default |
Member
There was a problem hiding this comment.
Overall the Helm 4 support implementation looks solid with proper backward compatibility for Helm 3. Found a few minor issues:
1. Bug: Error handling in certPoolFromFile function
Files: cmd/helm-cm-push/main_test.go (line 37) and pkg/chartmuseum/upload_test.go (line 33)
if !caCertPool.AppendCertsFromPEM(caCert) {
return nil, err // BUG: err is nil here from previous successful ReadFile
}Fix: Return a descriptive error instead:
if !caCertPool.AppendCertsFromPEM(caCert) {
return nil, fmt.Errorf("failed to append CA certs from PEM file: %s", filename)
}2. Typo in test file
File: pkg/helm/chart_test.go (lines 36, 39)
expexted should be expected
Contributor
Author
|
@nerdeveloper fixed |
Member
|
awesome work! |
This was referenced Feb 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref. #225