add php 8.4 support and bump workflow actions#10
Conversation
WalkthroughThe GitHub Actions build workflow was updated to add PHP 8.4 to the test matrix, upgrade the checkout action from version 2 to 4, and upgrade the composer-install action from version 2 to 3. No changes were made to code, logic, or exported entities. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/build.yml (2)
11-12: Confirm nightly availability or mark PHP 8.4 as an allowed-failure target
shivammathur/setup-phpwill attempt to install the latest nightly/dev build for a future minor (8.4) until it is officially released. Nightlies can break unexpectedly and fail the entire job.Consider guarding against that by either:
matrix: php-version: - "8.3" - - "8.4" + - "8.4" + fail-fast: false # don’t cancel the matrix on the first failure + + build: + continue-on-error: ${{ matrix.php-version == '8.4' }}(or splitting the 8.4 job into a separate,
allow-failurebuild).
This keeps stable branches green while still getting early signal from 8.4.
25-27: Composer-install v3 upgrade: double-check cache keys
ramsey/composer-install@v3changed its default cache key structure. If you rely on the old v2 key to share cache with other workflows you might see a cold-cache and longer install times on the first run.Nothing to fix here, just be aware and monitor the first pipeline run after merge.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build.yml(2 hunks)
🔇 Additional comments (1)
.github/workflows/build.yml (1)
17-17: Checkout v4 looks goodUpgrade to
actions/checkout@v4is compatible and benefits from the Node 20 runtime. No additional changes required.
Summary by CodeRabbit