ENT-13303: Fixed booleans for classes in augments#6024
Open
victormlg wants to merge 4 commits intocfengine:masterfrom
Open
ENT-13303: Fixed booleans for classes in augments#6024victormlg wants to merge 4 commits intocfengine:masterfrom
victormlg wants to merge 4 commits intocfengine:masterfrom
Conversation
victormlg
force-pushed
the
boolclassesaguments
branch
from
bd8e22a to
657aa1d
Compare
larsewi
reviewed
Jan 21, 2026
Ticket: ENT-13303 Signed-off-by: Victor Moene <victor.moene@northern.tech>
Signed-off-by: Victor Moene <victor.moene@northern.tech>
Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
boolclassesaguments
branch
from
657aa1d to
f670d8a
Compare
The "any" hard class is already defined in DetectEnvironment (sysinfo.c), where other hard classes are defined. Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
boolclassesaguments
branch
from
f670d8a to
e75e50b
Compare
larsewi
reviewed
Feb 4, 2026
| "augments_class_from_classexpression_or": [ "cfengine|cfengine_3::" ], | ||
| "augments_class_from_classexpression_complex": [ "(cfengine|cfengine_3).!MISSING::" ] | ||
| "augments_class_from_classexpression_complex": [ "(cfengine|cfengine_3).!MISSING::" ], | ||
| "augments_class_from_true": [ true ], |
Contributor
There was a problem hiding this comment.
In the ticket they do
{
"classes":
{
"data:my_class": true
}
}
not
{
"classes":
{
"data:my_class": [ true ]
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.