Repository navigation
refactor: stop seeding the cella migrations applied-set - #32
Merged
Merged
Conversation
The scaffold seeded cella/cella.migrations.json from the template's cella/migrations/manifest.json, so create-cella had to know the template's migration format. cella#1261 removes that manifest, and the template's run.ts now treats a missing applied-set as a new app: its first run records every migration on disk as applied. create-cella no longer touches migrations. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scaffold seeded
cella/cella.migrations.jsonfrom the template'scella/migrations/manifest.json, so create-cella had to know the template's migration format. cellajs/cella#1261 removes that manifest. In its place, the template'srun.tstreats a missing applied-set as a new app: its first run records every migration on disk as applied. With that, create-cella no longer touches migrations.Removed:
seedMigrationsAppliedSetand its call inclean-template.ts, and the e2e test that checked the seeded file.Merge after cellajs/cella#1261. Until then, the template's
run.tswould list a new app's whole migration history as pending.Checks:
pnpm ts,pnpm lint,pnpm test(36 passed).🤖 Generated with Claude Code