test: assert same-origin dev config in the release smoke test - #30
Merged
Merged
Conversation
The smoke test still expected PORT=4010 in backend/.env and a backendUrl on its own port, both dropped in #25. It runs in prepublishOnly, so it failed the publish step of the 0.3.8 and 0.3.9 releases and npm is still on 0.3.7. It now asserts the same-origin URLs, the offset devPorts block and that no PORT= line overrides them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm is stuck on 0.3.7 (2026-08-08). The publish step of the 0.3.8 and 0.3.9 releases failed:
pnpm publishrunsprepublishOnly→test:release, and the release smoke test still asserted the pre-#25 config shape.PORT=4010inbackend/.env. feat: generate same-origin configs with offset devPorts, fix fork detection #25 removed it on purpose, because aPORT=line overrides the devPorts offset.backendUrl: 'http://localhost:4010'andbackendAuthUrl: '.../auth'. These are now same-origin under the frontend port.Failed runs: 0.3.9, 0.3.8. The same test fails identically on current main.
The test now asserts the same-origin URLs, the full offset
devPortsblock (matching the unit test inenv-config.test.ts), and that.envhas noPORT=line.pnpm test:releasepasses locally against the livegithub:cellajs/cellatemplate.After merge:
test:doesn't cut a release, so re-run the Release workflow withworkflow_dispatchto publish 0.3.9 from main.🤖 Generated with Claude Code