Repository navigation
fix: emit .ts import extensions in generated env configs - #23
Merged
Merged
Conversation
cella now requires explicit .ts extensions on relative imports in shared/ (Vite 8 'native' config loader, enforced via Biome useImportExtensions — cellajs/cella#1033). generateEnvConfigs string-templates the import lines of shared/config/config.<mode>.ts, so freshly generated forks would fail the new lint rule and break under the future-default native loader. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to cellajs/cella#1033, which adds explicit
.tsextensions to all relative imports inshared/(Vite 8's future-default'native'config loader) and enforces them via Biome'suseImportExtensionsovershared/**.generateEnvConfigsstring-templates the import lines ofshared/config/config.<mode>.ts, so without this change a freshly generated fork immediately fails the new lint rule and would break config loading once Vite flips the default loader.Changes the three templated import strings (
config-builder/types,config.default,config.development) to carry.ts, plus the matching test assertions. All 35 tests pass.Should be released together with (or after) cellajs/cella#1033 landing in a cella release, per the known coupling between this generator and
config.*shape changes.🤖 Generated with Claude Code