Convert WebAuthn options endpoints from GET to POST#147
Merged
Conversation
RenzoMinelli
reviewed
Jul 7, 2026
| module Devise | ||
| class PasskeyAuthenticationOptionsController < DeviseController | ||
| def index | ||
| skip_forgery_protection |
Collaborator
Author
There was a problem hiding this comment.
Just to keep it simple in the JS side, as a forged options request can't do any harm: the session write only rotates the pending challenge.
RenzoMinelli
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #145.
Details
The four WebAuthn options endpoints (
passkey_registration_options,passkey_authentication_options,security_key_registration_optionsandsecurity_key_authentication_options) now respond toPOSTinstead ofGET: their routes and controllers were changed fromindextocreate(with forgery protection skipped), and the bundled JavaScript was updated to fetch the options with aPOSTrequest.