Fix Emacs28 compatibility and issue with default imap-user nil (#14)#15
Open
stasvlasov wants to merge 1 commit into
Open
Fix Emacs28 compatibility and issue with default imap-user nil (#14)#15stasvlasov wants to merge 1 commit into
stasvlasov wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues described in #14
The problem with loading token info from file (i.e. auth-source-xoauth2-creds is a string with file name) can be solved by adding user name/login to this file and setting user as nil in the hash-table because it seems that nnimap-credentials do not provide :user to the auth-source-search (just the default imap-user which is set to nil). The auth-source-xoauth2-creds could be then something like:
#s(hash-table size 2 test equal
data (("host1.com" nil "port1")
(:token-url "token-url-1"
:client-id "client-id-1"
:client-secret "client-secret-1"
:refresh-token "refresh-token-1"
:user "user-1")