Skip to content

test(java): add RSADigestSigner constructor edge-case coverage#410

Merged
san-zrl merged 1 commit into
cbomkit:mainfrom
sachin9058:feat/bouncycastle-signer-detection
May 20, 2026
Merged

test(java): add RSADigestSigner constructor edge-case coverage#410
san-zrl merged 1 commit into
cbomkit:mainfrom
sachin9058:feat/bouncycastle-signer-detection

Conversation

@sachin9058
Copy link
Copy Markdown
Contributor

This PR extends regression coverage for BouncyCastle signer edge cases related to RSADigestSigner.

What changed

  • Added a fixture covering the digest-only RSADigestSigner constructor path
  • Extended the existing test expectations to validate the additional finding
  • Verified the generated CBOM output remains consistent with the current RSA signature and digest relationship mapping

Investigation Notes

While working on this issue, I also reviewed the existing EC/DSA signer paths:

  • ECDSASigner support is already implemented through the existing BcDSA rule and mapper
  • Existing test coverage for that path is already present
  • DSADigestSigner currently resolves through the generic DSA translation flow, so I intentionally avoided adding misleading EC-specific assertions

This keeps the PR scoped specifically to improving regression coverage without changing current translation semantics.

Validation

mvn -pl java -Dtest=BcRSADigestSignerTest test
mvn test -pl java

Related

Closes part of #31

Signed-off-by: Sachin Kumar <sachinkumar905846@gmail.com>
Copilot AI review requested due to automatic review settings May 10, 2026 09:33
@sachin9058 sachin9058 requested a review from a team as a code owner May 10, 2026 09:33
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown
Contributor

@san-zrl san-zrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sachin9058 - LGTM. Thank you for your contribution to CBOMkit. This is highly appreciated.

@san-zrl san-zrl merged commit 8bb4445 into cbomkit:main May 20, 2026
4 of 6 checks passed
@sachin9058 sachin9058 deleted the feat/bouncycastle-signer-detection branch May 20, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants