test(java): add RSADigestSigner constructor edge-case coverage#410
Merged
san-zrl merged 1 commit intoMay 20, 2026
Merged
Conversation
Signed-off-by: Sachin Kumar <sachinkumar905846@gmail.com>
san-zrl
approved these changes
May 20, 2026
Contributor
san-zrl
left a comment
There was a problem hiding this comment.
Hi @sachin9058 - LGTM. Thank you for your contribution to CBOMkit. This is highly appreciated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends regression coverage for BouncyCastle signer edge cases related to
RSADigestSigner.What changed
RSADigestSignerconstructor pathInvestigation Notes
While working on this issue, I also reviewed the existing EC/DSA signer paths:
ECDSASignersupport is already implemented through the existingBcDSArule and mapperDSADigestSignercurrently resolves through the generic DSA translation flow, so I intentionally avoided adding misleading EC-specific assertionsThis keeps the PR scoped specifically to improving regression coverage without changing current translation semantics.
Validation
Related
Closes part of #31