fix(colors): make selection-bar text readable on every accent#119
Merged
Conversation
[Colors:Selection] put accent-family colors on the accent background, so the link (= the accent) rendered invisible and visited/status colors were unreadable on all 56 flavour x accent combos. point all selection foregrounds at one readable token (--selFg): crust on the accents, white on Latte's red/mauve/blue where crust is too low-contrast. worst-case contrast is now 4.77 (WCAG AA) across all combos. Closes #115
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
[Colors:Selection]link was the same color as the selection bar so it rendered invisible, and visited/status colors were low-contrast, across all 56 flavour×accent combos. now all selection foregrounds use one readable token: crust on the accents, white on Latte's red/mauve/blue where crust is too low-contrast. worst-case contrast goes from ~1.0 to 4.77 (WCAG AA).Closes #115
Reference images I made in html btw, incase anyone wants to see before and after. Not all colors were bad contrast but a very large majority were: