Step library release 1: fix certified-step defects, make certificatio… - #59
Merged
Merged
Conversation
…n honest Five certified steps carried real defects, and the `reviewed` badge asserted something nothing backed. This fixes both and completes the core step set. Step defects Fixed five defects in steps already published as certified. All were found while writing each README to the standard template: stating every computed field as an equation, and naming the provenance of every threshold, forced questions that code review had skipped. Certification levels `reviewed` now means a named person approved the pull request that last changed the step. Split into two levels so the automated gate has its own word — `gated` passes every conformance check, `reviewed` is gated plus human approval. Method provenance moved from README prose into `method.citation`, so the machine-readable half agrees with the human half. Step set Completed the remaining core utilities. Aligned which options a researcher may configure across steps, and fixed field names that did not survive a change of time grid. Packaging No Python environment ships in the built jar — `jvmProcessResources` excludes in both the demo and steps modules, mirroring `StepContentHash.TRANSIENT`: what is not part of a step's identity is not part of its package. Committed `scripts/eval/pixi.lock`; the manifest pins nothing, so the lock is the only record of the resolved environment. Verification All 12 steps assert `test_reproduces_the_reference_fixture`, each checked by perturbing a fixture value and confirming the test fails. Added and registered `library-minimal` and `library-anomaly` so `run-all-demos` covers all three v2 workflows; verified green against real data.
📊 Coverage ReportCoverage reports have been generated and uploaded to Codecov.
Quick StatsThe coverage report will be available once processing completes on Codecov. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
- Coverage 81.89% 80.15% -1.75%
==========================================
Files 79 91 +12
Lines 3330 3688 +358
Branches 569 667 +98
==========================================
+ Hits 2727 2956 +229
- Misses 392 466 +74
- Partials 211 266 +55 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n honest
Five certified steps carried real defects, and the
reviewedbadge asserted something nothing backed. This fixes both and completes the core step set.Step defects
Fixed five defects in steps already published as certified. All were found while writing each README to the standard template: stating every computed field as an equation, and naming the provenance of every threshold, forced questions that code review had skipped.
Certification levels
reviewednow means a named person approved the pull request that last changed the step. Split into two levels so the automated gate has its own word —gatedpasses every conformance check,reviewedis gated plus human approval. Method provenance moved from README prose intomethod.citation, so the machine-readable half agrees with the human half.Step set
Completed the remaining core utilities. Aligned which options a researcher may configure across steps, and fixed field names that did not survive a change of time grid.
Packaging
No Python environment ships in the built jar —
jvmProcessResourcesexcludes in both the demo and steps modules, mirroringStepContentHash.TRANSIENT: what is not part of a step's identity is not part of its package. Committedscripts/eval/pixi.lock; the manifest pins nothing, so the lock is the only record of the resolved environment.Verification
All 12 steps assert
test_reproduces_the_reference_fixture, each checked by perturbing a fixture value and confirming the test fails. Added and registeredlibrary-minimalandlibrary-anomalysorun-all-demoscovers all three v2 workflows; verified green against real data.