Fix flaky MultiHostValidatorOperator topology serial race#5748
Draft
martinflorian-da wants to merge 1 commit into
Draft
Fix flaky MultiHostValidatorOperator topology serial race#5748martinflorian-da wants to merge 1 commit into
martinflorian-da wants to merge 1 commit into
Conversation
Fixes DACH-NY/cn-test-failures#8444 [ci] Theory: After bobValidator reconnects, its participant's topology store can still lag behind the party-to-participant change aliceValidator authorized while bob was disconnected. "Clear the onboarding flags" possibly races with catching up to topology and therefore gets rejected with TOPOLOGY_SERIAL_MISMATCH. The best smoking gun I have for this from the logs is that reconnect finishes at `2026-05-18T06:52:39.586Z `, then we try the propose at `2026-05-18T06:52:39.631`. This is very short time... So either this really fixes it or we have better proof that somehow a topology transaction disappears again (if this is what happens). Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
martinflorian-da
force-pushed
the
martinflorian-da/cntf-8444-fix-multihost-validator-topology-serial-race
branch
from
597dd33 to
639ddab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DACH-NY/cn-test-failures#8444
[ci]
Theory: After bobValidator reconnects, its participant's topology store can still lag behind the party-to-participant change aliceValidator authorized while bob was disconnected. "Clear the onboarding flags" possibly races with catching up to topology and therefore gets rejected with TOPOLOGY_SERIAL_MISMATCH.
The best smoking gun I have for this from the logs is that reconnect finishes at
2026-05-18T06:52:39.586Z, then we try the propose at2026-05-18T06:52:39.631. This is very short time...So either this really fixes it or we have better proof that somehow a topology transaction disappears again (if this is what happens).
Signed-off-by: Martin Florian martin.florian@digitalasset.com