Skip to content

refactor: split every file over 1,000 lines into topic files - #1582

Merged
V3RON merged 83 commits into
mainfrom
t3/decompose-large-files
Nov 16, 2026
Merged

V3RON merged 83 commits into
mainfrom
t3/decompose-large-files

Conversation

@V3RON

@V3RON V3RON commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Splits every tracked code and test file over 1,000 lines into files that group related code, each named for what it holds. No behaviour changes: every module's entry file exports the same names. After this PR no file is over 1,000 lines, and SHRINK_ONLY in source-hygiene.test.ts is empty.

The five big classes (iOS driver, lease-acquisition coordinator, fleet coordinator, daemon dispatcher, daemon server) follow ADR 0063: one composition root over parts that own their state, with no import cycles. The other code files were moved into topic files that their entry file re-exports. The 52 test files were split by describe, with shared setup in test-*.ts helpers.

Tooling changed so that a split code move passes the hooks:

  • Comment lint: a block moved unchanged, or a directive added beside a comment, is not new.
  • Test lint: a test line or internal import that a split carries over is not new.
  • testing-only-in-tests: a testing.ts entry may import test-*.ts helpers.
  • Fallow: suppressions and the two complexity overrides follow the moved code.

Not done here: refactor issues, pin tests and the mutation run (delivery rule 18). The maintainer chose to land this without them.

Review

Spec review: skipped. Code review: 0 blocking, 2 fixed, 2 notes. Claims review: 0 blocking, 1 fixed, 1 notes.
Assessment: complete — round 1 at dc10f6e (code and claims lenses), a fix-check at abc46bf that ran no lens, and a targeted round 2 at f5305a5 (code and claims lenses), which found nothing.
Rejected: claims: device-selection.md:13 and console-redesign/PLAN.md:200 name operations.ts locations that were already wrong at the merge base (out of scope); the docs-surface-check.mjs header wording "the parts it re-exports" is loose, not false (nonblocking).
Rounds: 3. Tokens: 15M.

Fixed: R1 stale pre-split pointers in comments and docs (edited comments rewritten to architecture rule 17); R2 the docs-surface gate watched only config.ts after the split; R3 it also missed config-alerts.ts, which pre-dates this PR.

Notes (from the orchestrator's own checks before the blind review):

  • code: some src/cli tests pass only after earlier tests in their file have warmed module state, so their grouping is fragile.
  • code: the test-lint carry-over excuse lets a moved skip, toBeInstanceOf(Error) or internal import through unchanged; a new one is still flagged.
  • claims: two new why: comments in src/cli/index-environment-helpers.test.ts and index-lease-requests.test.ts call the CLI environment builder "a part of a decomposed module"; check that wording.

Written by an agent.

V3RON added 30 commits November 15, 2026 19:01
Moves the pure constants to spec-lint-patterns.mjs and the pure text and reference helpers to spec-lint-text.mjs. The feature checks read the run's parsed body and issue state, so they stay in the root; the CLI output and exit codes are unchanged.
Pure structure split: types, defaults, role checks, validators and generic helpers move to sibling files; config.ts keeps the entry point and every previous export.
Protocol-bump: none (refactor: operations.ts split into files, no wire shape changes)
V3RON added 19 commits November 15, 2026 19:35
…s, boot, DeviceHub, slim, catalog, components and seeds parts
The config, contract and client files were split into parts that the same entry files re-export;
no key, default, operation, wire shape or client method changed.

Docs: none (structure-only split; every public name and behaviour is unchanged)
@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 421 files, which is 271 over the limit of 150.

To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

Usage-priced reviews support at most 300 files.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: QUIET
  • Plan: Advanced
  • Run ID: f931a554-31e0-4559-9bb8-119da29214b3
Commits

Reviewing files that changed from the base of the PR and between 6db7d04 and f5305a5.

Files selected for processing: 421

  • .agents/scripts/comments.mjs
  • .agents/scripts/docs-surface-check.mjs
  • .agents/scripts/spec-lint-patterns.mjs
  • .agents/scripts/spec-lint-text.mjs
  • .agents/scripts/spec-lint.mjs
  • .agents/scripts/test-lint.mjs
  • .dependency-cruiser.mjs
  • .fallowrc.json
  • docs/internal/flows/device-exec.md
  • docs/internal/flows/device-selection.md
  • e2e/fake-driver/fake-driver.ts
  • e2e/physical-enrollment-auto-enroll.test.ts
  • e2e/physical-enrollment-enrolled.test.ts
  • e2e/physical-enrollment-transports.test.ts
  • e2e/physical-enrollment.test.ts
  • e2e/test-physical-enrollment.ts
  • src/agent-device/edge-allocate-placement.test.ts
  • src/agent-device/edge-allocate.test.ts
  • src/agent-device/edge-fake-agent-device.test.ts
  • src/agent-device/edge-heartbeat.test.ts
  • src/agent-device/edge-release.test.ts
  • src/agent-device/edge-request-rules-devices.test.ts
  • src/agent-device/edge-request-rules.test.ts
  • src/agent-device/edge.test.ts
  • src/agent-device/gateway-front-lease-header.test.ts
  • src/agent-device/gateway-front-lease.test.ts
  • src/agent-device/gateway-front-reconnect.test.ts
  • src/agent-device/gateway-front.test.ts
  • src/agent-device/host/agent-device-supervisor-lifecycle.test.ts
  • src/agent-device/host/agent-device-supervisor-phones.test.ts
  • src/agent-device/host/agent-device-supervisor-state.test.ts
  • src/agent-device/host/agent-device-supervisor.test.ts
  • src/agent-device/host/agent-device-supervisor.ts
  • src/agent-device/host/test-agent-device-supervisor.ts
  • src/agent-device/test-edge-front.ts
  • src/agent-device/test-edge-request-rules.ts
  • src/agent-device/test-gateway-front.ts
  • src/agent-device/testing.ts
  • src/cli/index-admin-auto-launch.test.ts
  • src/cli/index-admin-holder-renew.test.ts
  • src/cli/index-auto-launch-handshake.test.ts
  • src/cli/index-baseline-alerts-warm.test.ts
  • src/cli/index-catalog-components.test.ts
  • src/cli/index-daemon-service.test.ts
  • src/cli/index-daemon-status.test.ts
  • src/cli/index-device-config.test.ts
  • src/cli/index-environment-helpers.test.ts
  • src/cli/index-events-mcp-smoke.test.ts
  • src/cli/index-exit-codes-passthrough.test.ts
  • src/cli/index-lease-requests.test.ts
  • src/cli/index-status-daemon-lines.test.ts
  • src/cli/index-status-warm-pool.test.ts
  • src/cli/index-update-status-stats.test.ts
  • src/cli/index-worker.test.ts
  • src/cli/index.test.ts
  • src/cli/test-index.ts
  • src/cli/test-tunnel.ts
  • src/cli/tunnel-connections.test.ts
  • src/cli/tunnel-forward-and-emulator.test.ts
  • src/cli/tunnel.test.ts
  • src/comment-lint.test.ts
  • src/contract/AGENTS.md
  • src/contract/operation-definition.ts
  • src/contract/operations-admin.ts
  • src/contract/operations-fleet.ts
  • src/contract/operations-lease-device-daemon.test.ts
  • src/contract/operations-lease-request.ts
  • src/contract/operations-leases.ts
  • src/contract/operations-round-trips-catalog-config.test.ts
  • src/contract/operations-round-trips-lease-status.test.ts
  • src/contract/operations.test.ts
  • src/contract/operations.ts
  • src/contract/protocol.ts
  • src/contract/roles.ts
  • src/contract/schemas-fit-and-doctor.test.ts
  • src/contract/schemas-worker-status.test.ts
  • src/contract/schemas.test.ts
  • src/core/capacity/AGENTS.md
  • src/core/component-installer-list-and-in-progress.test.ts
  • src/core/component-installer-outcomes.test.ts
  • src/core/component-installer-remove.test.ts
  • src/core/component-installer-timeouts-and-close.test.ts
  • src/core/component-installer.test.ts
  • src/core/component-installer.ts
  • src/core/config-auth-and-proxy.test.ts
  • src/core/config-capacity.test.ts
  • src/core/config-defaults.ts
  • src/core/config-health-downloads-http.test.ts
  • src/core/config-helpers.ts
  • src/core/config-lease.test.ts
  • src/core/config-modes.test.ts
  • src/core/config-platform-and-driver-settings.test.ts
  • src/core/config-redact.test.ts
  • src/core/config-role-checks.ts
  • src/core/config-types.ts
  • src/core/config-validators.ts
  • src/core/config-warm-pool.test.ts
  • src/core/config.test.ts
  • src/core/config.ts
  • src/core/device-provisioner.test.ts
  • src/core/doctor-drift.ts
  • src/core/doctor-findings.ts
  • src/core/doctor-observed-state.test.ts
  • src/core/doctor-physical-devices.test.ts
  • src/core/doctor-types.ts
  • src/core/doctor-unobservable-platform.test.ts
  • src/core/doctor-warm-pool-targets.test.ts
  • src/core/doctor.test.ts
  • src/core/doctor.ts
  • src/core/fake-device-tcp.ts
  • src/core/fake-driver.ts
  • src/core/index.ts
  • src/core/quarantine-coordinator-cause.test.ts
  • src/core/quarantine-coordinator-physical-presence.test.ts
  • src/core/quarantine-coordinator.test.ts
  • src/core/quarantine-coordinator.ts
  • src/core/registry-component-records.test.ts
  • src/core/registry-errors.ts
  • src/core/registry-leases.test.ts
  • src/core/registry-quarantine-cause.test.ts
  • src/core/registry-quarantine.test.ts
  • src/core/registry-records.ts
  • src/core/registry-transition-event.test.ts
  • src/core/registry-types.ts
  • src/core/registry.test.ts
  • src/core/registry.ts
  • src/core/test-component-installer.ts
  • src/core/test-config.ts
  • src/core/test-doctor-observed.ts
  • src/core/test-quarantine-coordinator.ts
  • src/core/test-registry-corrupt-row.ts
  • src/core/warm-pool/converger-memory-pressure.test.ts
  • src/core/warm-pool/converger-targets-creation.test.ts
  • src/core/warm-pool/converger-targets-passes.test.ts
  • src/core/warm-pool/converger-targets-reports.test.ts
  • src/core/warm-pool/converger.test.ts
  • src/core/warm-pool/learned-kinds-forget.test.ts
  • src/core/warm-pool/learned-kinds.test.ts
  • src/core/warm-pool/policy-learned-kinds.test.ts
  • src/core/warm-pool/policy-memory-pressure.test.ts
  • src/core/warm-pool/policy-targeted-devices.test.ts
  • src/core/warm-pool/policy-targets.test.ts
  • src/core/warm-pool/policy.test.ts
  • src/core/warm-pool/test-converger.ts
  • src/core/warm-pool/test-policy.ts
  • src/daemon/dispatcher-admin.ts
  • src/daemon/dispatcher-baseline-lease.test.ts
  • src/daemon/dispatcher-baseline-list.test.ts
  • src/daemon/dispatcher-baseline-remove.test.ts
  • src/daemon/dispatcher-baseline-replace.test.ts
  • src/daemon/dispatcher-baseline-save.test.ts
  • src/daemon/dispatcher-capabilities.ts
  • src/daemon/dispatcher-components.ts
  • src/daemon/dispatcher-device-views.ts
  • src/daemon/dispatcher-devices.ts
  • src/daemon/dispatcher-events.test.ts
  • src/daemon/dispatcher-events.ts
  • src/daemon/dispatcher-exec.test.ts
  • src/daemon/dispatcher-exec.ts
  • src/daemon/dispatcher-fleet.ts
  • src/daemon/dispatcher-leases-capacity.test.ts
  • src/daemon/dispatcher-leases-device-mode.test.ts
  • src/daemon/dispatcher-leases-request-outcomes.test.ts
  • src/daemon/dispatcher-leases.test.ts
  • src/daemon/dispatcher-leases.ts
  • src/daemon/dispatcher-options.ts
  • src/daemon/dispatcher-status.ts
  • src/daemon/dispatcher-usage.test.ts
  • src/daemon/dispatcher.test.ts
  • src/daemon/dispatcher.ts
  • src/daemon/error-code.ts
  • src/daemon/gateway-fleet.e2e.test.ts
  • src/daemon/main-history.test.ts
  • src/daemon/main-leasing.test.ts
  • src/daemon/main-start-daemon.test.ts
  • src/daemon/main-state-db.test.ts
  • src/daemon/main-worker-lock.test.ts
  • src/daemon/main.test.ts
  • src/daemon/optional-modules-start.test.ts
  • src/daemon/optional-modules-stop.test.ts
  • src/daemon/optional-modules.test.ts
  • src/daemon/relay-gateway-bodies.e2e.test.ts
  • src/daemon/relay-gateway-cancel.e2e.test.ts
  • src/daemon/relay-gateway-capacity.e2e.test.ts
  • src/daemon/relay-gateway-files.e2e.test.ts
  • src/daemon/relay-gateway.e2e.test.ts
  • src/daemon/server-claim-and-stop.test.ts
  • src/daemon/server-drivers.test.ts
  • src/daemon/server-leases.test.ts
  • src/daemon/server-options.ts
  • src/daemon/server-pushes.test.ts
  • src/daemon/server-requests.test.ts
  • src/daemon/server-requests.ts
  • src/daemon/server.test.ts
  • src/daemon/server.ts
  • src/daemon/test-main-history.ts
  • src/daemon/test-main-state.ts
  • src/daemon/test-optional-modules.ts
  • src/daemon/test-relay-gateway.ts
  • src/daemon/worker-composition.ts
  • src/docs-surface-check.test.ts
  • src/drivers/android/catalog-device-list.test.ts
  • src/drivers/android/catalog-library-and-resolve.test.ts
  • src/drivers/android/catalog-refusals-and-fit.test.ts
  • src/drivers/android/catalog.test.ts
  • src/drivers/android/index-boot.test.ts
  • src/drivers/android/index-copies-recovery.test.ts
  • src/drivers/android/index-device-tcp.test.ts
  • src/drivers/android/index-image-fit.test.ts
  • src/drivers/android/index-launch.test.ts
  • src/drivers/android/index-lifecycle.test.ts
  • src/drivers/android/index-profiles-components.test.ts
  • src/drivers/android/index-screen-capture.test.ts
  • src/drivers/android/index.test.ts
  • src/drivers/android/index.ts
  • src/drivers/android/physical-handler-inspect-list.test.ts
  • src/drivers/android/physical-handler-passthrough.test.ts
  • src/drivers/android/physical-handler-windows.test.ts
  • src/drivers/android/physical-handler.test.ts
  • src/drivers/android/screen/session-body-and-close.test.ts
  • src/drivers/android/screen/session-phone-screen-state.test.ts
  • src/drivers/android/screen/session.test.ts
  • src/drivers/android/screen/test-session.ts
  • src/drivers/android/seeds-copies.test.ts
  • src/drivers/android/seeds-library-and-fit.test.ts
  • src/drivers/android/seeds.test.ts
  • src/drivers/android/test-catalog.ts
  • src/drivers/android/test-driver-harness.ts
  • src/drivers/android/test-emulator-host.ts
  • src/drivers/android/test-index-lifecycle.ts
  • src/drivers/android/test-index.ts
  • src/drivers/android/test-physical-handler.ts
  • src/drivers/android/test-sdk-fixtures.ts
  • src/drivers/android/test-seed-harness.ts
  • src/drivers/android/test-seeds.ts
  • src/drivers/android/testing.ts
  • src/drivers/ios/catalog.ts
  • src/drivers/ios/command-run.ts
  • src/drivers/ios/components.ts
  • src/drivers/ios/devicehub.ts
  • src/drivers/ios/driver-options.ts
  • src/drivers/ios/index-component-install.test.ts
  • src/drivers/ios/index-device-set.test.ts
  • src/drivers/ios/index-list-components.test.ts
  • src/drivers/ios/index-passthrough.test.ts
  • src/drivers/ios/index-provenance-root.test.ts
  • src/drivers/ios/index-remove-component.test.ts
  • src/drivers/ios/index-save-source-lifecycle.test.ts
  • src/drivers/ios/index-screen-tool-versions.test.ts
  • src/drivers/ios/index-seed-provision.test.ts
  • src/drivers/ios/index-seed-sources.test.ts
  • src/drivers/ios/index-simulator-audio.test.ts
  • src/drivers/ios/index-slim-mode.test.ts
  • src/drivers/ios/index-slim-resolve-advisories.test.ts
  • src/drivers/ios/index.test.ts
  • src/drivers/ios/index.ts
  • src/drivers/ios/marks.ts
  • src/drivers/ios/passthrough-rules.ts
  • src/drivers/ios/physical-files-and-limits.test.ts
  • src/drivers/ios/physical-presence.test.ts
  • src/drivers/ios/physical.test.ts
  • src/drivers/ios/runtime-images.ts
  • src/drivers/ios/runtime-versions.ts
  • src/drivers/ios/seeds.ts
  • src/drivers/ios/simctl.ts
  • src/drivers/ios/simulator-boot.ts
  • src/drivers/ios/simulator-data.ts
  • src/drivers/ios/slim-boot.ts
  • src/drivers/ios/test-index.ts
  • src/drivers/ios/test-physical.ts
  • src/gateway/aggregate-catalog.test.ts
  • src/gateway/aggregate.test.ts
  • src/gateway/dispatcher-alerts-and-refusals.test.ts
  • src/gateway/dispatcher-baselines.test.ts
  • src/gateway/dispatcher-events-tokens.test.ts
  • src/gateway/dispatcher-lease-lifecycle.test.ts
  • src/gateway/dispatcher-leases.test.ts
  • src/gateway/dispatcher.test.ts
  • src/gateway/dispatcher.ts
  • src/gateway/fleet-admission.ts
  • src/gateway/fleet-coordinator-exec.test.ts
  • src/gateway/fleet-coordinator-forwarding.test.ts
  • src/gateway/fleet-coordinator-view-and-release.test.ts
  • src/gateway/fleet-coordinator-walk.test.ts
  • src/gateway/fleet-coordinator.test.ts
  • src/gateway/fleet-coordinator.ts
  • src/gateway/fleet-dispatch.ts
  • src/gateway/fleet-facts.ts
  • src/gateway/fleet-grant.ts
  • src/gateway/fleet-index-upkeep.ts
  • src/gateway/fleet-request-shape.ts
  • src/gateway/fleet-requests-outcomes.test.ts
  • src/gateway/fleet-requests-requester-limit.test.ts
  • src/gateway/fleet-requests-waiting-reasons.test.ts
  • src/gateway/fleet-requests.test.ts
  • src/gateway/fleet-routing-ranges-and-except.test.ts
  • src/gateway/fleet-routing-starting-and-physical.test.ts
  • src/gateway/fleet-routing.test.ts
  • src/gateway/relay-failures.test.ts
  • src/gateway/relay.test.ts
  • src/gateway/service-link-lifecycle.test.ts
  • src/gateway/service-relays-and-refresh.test.ts
  • src/gateway/service-worker-protocol.test.ts
  • src/gateway/service.test.ts
  • src/gateway/test-aggregate.ts
  • src/gateway/test-relay.ts
  • src/gateway/test-service.ts
  • src/gateway/test-worker-registry.ts
  • src/gateway/worker-registry-load-and-disconnect.test.ts
  • src/gateway/worker-registry-views-changed.test.ts
  • src/gateway/worker-registry.test.ts
  • src/gateway/worker-registry.ts
  • src/history/history-prune.test.ts
  • src/history/history-reader.test.ts
  • src/history/history-start-recovery.test.ts
  • src/history/history.test.ts
  • src/history/projections/usage/test-usage.ts
  • src/history/projections/usage/usage-device-facts-reads.test.ts
  • src/history/projections/usage/usage-minutes.test.ts
  • src/history/projections/usage/usage-versions-rebuild-prune.test.ts
  • src/history/projections/usage/usage.test.ts
  • src/history/test-history.ts
  • src/http/app-helpers.ts
  • src/http/app-lease-request-routes.ts
  • src/http/app-lease-routes.ts
  • src/http/app-leases-files.test.ts
  • src/http/app-leases-lease-routes.test.ts
  • src/http/app-leases.test.ts
  • src/http/app-operator-listings.test.ts
  • src/http/app-stream-and-caching.test.ts
  • src/http/app-types.ts
  • src/http/app-updates.test.ts
  • src/http/app-worker-routes.test.ts
  • src/http/app.test.ts
  • src/http/app.ts
  • src/http/errors.ts
  • src/http/notices.ts
  • src/http/tracker.ts
  • src/lease-policy/index.ts
  • src/leasing/acquisition-admission.ts
  • src/leasing/acquisition-errors.ts
  • src/leasing/acquisition-gates.ts
  • src/leasing/acquisition-ports.ts
  • src/leasing/acquisition-spec-resolver.ts
  • src/leasing/acquisition-waiter.ts
  • src/leasing/acquisition-workflow.ts
  • src/leasing/create-leasing-baseline-pools.test.ts
  • src/leasing/create-leasing-capacity-events.test.ts
  • src/leasing/create-leasing-fresh-identity.test.ts
  • src/leasing/create-leasing-gateway-and-retry.test.ts
  • src/leasing/create-leasing-grant-and-queue.test.ts
  • src/leasing/create-leasing-lease-id.test.ts
  • src/leasing/create-leasing-max-per-requester.test.ts
  • src/leasing/create-leasing-ram-budget.test.ts
  • src/leasing/create-leasing-rejections.test.ts
  • src/leasing/create-leasing-restart-and-classes.test.ts
  • src/leasing/create-leasing-startup-reclaim.test.ts
  • src/leasing/create-leasing-waiting-reasons.test.ts
  • src/leasing/create-leasing-warm-pool.test.ts
  • src/leasing/create-leasing-warm-targets.test.ts
  • src/leasing/create-leasing-wiring-and-logger.test.ts
  • src/leasing/create-leasing.test.ts
  • src/leasing/lease-acquisition-coordinator-device-mode.test.ts
  • src/leasing/lease-acquisition-coordinator-failed-boots.test.ts
  • src/leasing/lease-acquisition-coordinator-reported-events.test.ts
  • src/leasing/lease-acquisition-coordinator-stored-requests.test.ts
  • src/leasing/lease-acquisition-coordinator-waiting-and-baselines.test.ts
  • src/leasing/lease-acquisition-coordinator.test.ts
  • src/leasing/lease-acquisition-coordinator.ts
  • src/leasing/lease-end-participants-nuke-settle-and-restarts.test.ts
  • src/leasing/lease-end-participants-startup-and-ceilings.test.ts
  • src/leasing/lease-end-participants.test.ts
  • src/leasing/physical-device-watcher-acting.test.ts
  • src/leasing/physical-device-watcher-restarts-and-nuke.test.ts
  • src/leasing/physical-device-watcher.test.ts
  • src/leasing/test-create-leasing.ts
  • src/leasing/test-lease-acquisition-commits.ts
  • src/leasing/test-lease-end-participants.ts
  • src/leasing/test-physical-device-watcher.ts
  • src/leasing/waiter-outcomes.ts
  • src/mcp/server-devices.test.ts
  • src/mcp/server-run-on-device.test.ts
  • src/mcp/server.test.ts
  • src/mcp/session-lease-endings.test.ts
  • src/mcp/session-reconnect.test.ts
  • src/mcp/session-release.test.ts
  • src/mcp/session-renewal.test.ts
  • src/mcp/session.test.ts
  • src/mcp/session.ts
  • src/mcp/test-server.ts
  • src/mcp/test-session.ts
  • src/ports/node-process-runner.ts
  • src/ports/process-line-buffer.ts
  • src/ports/process-runner-types.ts
  • src/ports/process-runner.test.ts
  • src/ports/process-runner.ts
  • src/ports/process-tree-kill.ts
  • src/ports/scripted-process-runner.ts
  • src/simlock-client/client-admin.test.ts
  • src/simlock-client/client-api.ts
  • src/simlock-client/client-degraded.ts
  • src/simlock-client/client-errors.ts
  • src/simlock-client/client-impl.ts
  • src/simlock-client/client-pushes.test.ts
  • src/simlock-client/client-request-lease.test.ts
  • src/simlock-client/client.test.ts
  • src/simlock-client/client.ts
  • src/simlock-client/test-client.ts
  • src/simlock-client/types.ts
  • src/simlock-client/wire.ts
  • src/source-hygiene.test.ts
  • src/spec-lint-design.test.ts
  • src/spec-lint-feature.test.ts
  • src/spec-lint-refactor.test.ts
  • src/spec-lint.test.ts
  • src/test-lint.test.ts
  • src/test-spec-lint.ts
  • src/tunnel/test-worker.ts
  • src/tunnel/worker-emulator-tunnel.test.ts
  • src/tunnel/worker-forward-tunnels.test.ts
  • src/tunnel/worker.test.ts

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@V3RON

V3RON commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor Author

Review ledger

Round 1: dc10f6e
Round fix-check: abc46bf
Round 2: f5305a5

Runs: 7. Cost USD: 6.242. Agent seconds: 3189.
Tokens input 346, output 102943, cache read 13975237, cache write 642880.
- review 1 reviewer: claude-sonnet-5-5 1196 s $0.5105
- review 1 code behaviour: claude-opus-5-5 664 s $4.002
- review 1 claims: claude-sonnet-5-5 274 s $0.5969
- review fix-check reviewer: claude-sonnet-5-5 321 s $0.305
- review 2 reviewer: claude-sonnet-5-5 558 s $0.2343
- review 2 code behaviour: claude-opus-5-5 123 s $0.4122
- review 2 claims: claude-sonnet-5-5 53 s $0.1811
Finding outcomes: {"fixed":3}. Classes: {"docs-surface config surface omitted config-alerts.ts":1,"docs-surface config surface watched only config.ts":1,"stale pre-split pointers":1}.
{"findings":[{"id":"R1","role":"claims","class":"stale pre-split pointers","outcome":"fixed","path":"multiple","round":"1","fix":"abc46bfded7d46b3cc5ee5a11108c98489588287"},{"id":"R2","role":"code","class":"docs-surface config surface watched only config.ts","outcome":"fixed","path":".agents/scripts/docs-surface-check.mjs","round":"1","fix":"73fc87c1fae0c05ec1272c152d35837d6a6bcabd"},{"id":"R3","role":"code","class":"docs-surface config surface omitted config-alerts.ts","outcome":"fixed","path":".agents/scripts/docs-surface-check.mjs","round":"2","fix":"f5305a5ab62586a7ffbf0d5fdf2186dd652f8f97"}]}

Written by an agent.

Comment on lines +112 to +121
const child = spawnChildProcess(launch.command, launch.args, {
...(options.cwd === undefined ? {} : { cwd: options.cwd }),
...(options.env === undefined ? {} : { env: options.env }),
detached: process.platform !== "win32",
stdio: childStdio(options.stdio, logFd),
// why: the daemon has no console, so on Windows a console program it starts (adb, the
// emulator, node) would otherwise get a new, visible one.
windowsHide: true,
windowsVerbatimArguments: launch.windowsVerbatimArguments,
});
Comment on lines +156 to +164
const child = spawnChildProcess(launch.command, launch.args, {
...(options.cwd === undefined ? {} : { cwd: options.cwd }),
...(options.env === undefined ? {} : { env: options.env }),
detached: process.platform !== "win32",
stdio: "pipe",
// why: as in `spawn`: no visible console window for a child of a daemon that has none.
windowsHide: true,
windowsVerbatimArguments: launch.windowsVerbatimArguments,
});
…essions for members only tests reach through a harness
…split into

The gate watched only src/core/config.ts, so after the split a change to the
config type, defaults or validators passed with no website page changed.
…ments say why

Comments and flow docs still named pre-split locations. An edited comment
must follow architecture rule 17, so those blocks now say why without
pointing elsewhere, or are gone.
@V3RON
V3RON marked this pull request as ready for review November 16, 2026 08:36
@V3RON
V3RON merged commit 5e639b4 into main Nov 16, 2026
66 checks passed
@V3RON
V3RON deleted the t3/decompose-large-files branch November 16, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants