Conversation
There was a problem hiding this comment.
Pull request overview
This PR bumps the library to v1.10.0 and adds a new Speech-to-Text API for language detection, wiring it through the React Native Nitro spec and the C++ hybrid module, alongside an updated iOS cactus.xcframework drop.
Changes:
- Add
detectLanguageto the STT TypeScript types, JS wrapper, Nitro spec, and C++ HybridCactus implementation. - Update generated Nitro bindings to register the new hybrid method.
- Bump package/CocoaPods versions and update the vendored iOS framework headers/binaries.
Reviewed changes
Copilot reviewed 24 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/types/CactusSTT.ts | Adds TS types for detectLanguage params/options/result. |
| src/specs/Cactus.nitro.ts | Extends Nitro hybrid spec with detectLanguage(...). |
| src/native/Cactus.ts | Implements JS-facing detectLanguage wrapper calling the hybrid method. |
| src/index.tsx | Re-exports new STT detect-language types from the public API. |
| src/classes/CactusSTT.ts | Exposes CactusSTT.detectLanguage(...) high-level method. |
| package.json | Bumps npm package version to 1.10.0. |
| nitrogen/generated/shared/c++/HybridCactusSpec.hpp | Updates generated C++ spec with detectLanguage virtual method. |
| nitrogen/generated/shared/c++/HybridCactusSpec.cpp | Registers detectLanguage in the generated hybrid prototype. |
| cpp/cactus_ffi.h | Adds cactus_detect_language and expands telemetry FFI surface. |
| cpp/HybridCactus.hpp | Declares HybridCactus::detectLanguage(...). |
| cpp/HybridCactus.cpp | Implements detectLanguage(...) and updates telemetry environment call/version. |
| ios/cactus.xcframework/ios-arm64/cactus.framework/Info.plist | Updates vendored iOS device framework metadata (binary plist). |
| ios/cactus.xcframework/ios-arm64/cactus.framework/Headers/kernel_utils.h | Updates vendored device headers (CPU feature detection, int4 helpers, threading tweaks). |
| ios/cactus.xcframework/ios-arm64/cactus.framework/Headers/kernel.h | Updates vendored device kernel API declarations (new ops, signatures). |
| ios/cactus.xcframework/ios-arm64/cactus.framework/Headers/graph.h | Updates vendored device graph API/types (new ops, INT4 support helpers, etc.). |
| ios/cactus.xcframework/ios-arm64/cactus.framework/Headers/engine.h | Updates vendored device engine API/types/config fields. |
| ios/cactus.xcframework/ios-arm64/cactus.framework/Headers/cactus_utils.h | Updates vendored device utility header (env helpers, JSON helpers, options parsing changes, etc.). |
| ios/cactus.xcframework/ios-arm64/cactus.framework/Headers/cactus_ffi.h | Adds detect-language FFI and telemetry API changes (device slice). |
| ios/cactus.xcframework/ios-arm64/cactus.framework/Headers/cactus_cloud.h | Adds new vendored device header for cloud-related helpers. |
| ios/cactus.xcframework/ios-arm64-simulator/cactus.framework/_CodeSignature/CodeResources | Updates simulator framework code signature resources. |
| ios/cactus.xcframework/ios-arm64-simulator/cactus.framework/Info.plist | Updates vendored iOS simulator framework metadata (binary plist). |
| ios/cactus.xcframework/ios-arm64-simulator/cactus.framework/Headers/kernel_utils.h | Updates vendored simulator headers (mirrors device header changes). |
| ios/cactus.xcframework/ios-arm64-simulator/cactus.framework/Headers/kernel.h | Updates vendored simulator kernel API declarations. |
| ios/cactus.xcframework/ios-arm64-simulator/cactus.framework/Headers/graph.h | Updates vendored simulator graph API/types. |
| ios/cactus.xcframework/ios-arm64-simulator/cactus.framework/Headers/engine.h | Updates vendored simulator engine API/types/config fields. |
| ios/cactus.xcframework/ios-arm64-simulator/cactus.framework/Headers/cactus_utils.h | Updates vendored simulator utility header (mirrors device header changes). |
| ios/cactus.xcframework/ios-arm64-simulator/cactus.framework/Headers/cactus_ffi.h | Adds detect-language FFI and telemetry API changes (simulator slice). |
| ios/cactus.xcframework/ios-arm64-simulator/cactus.framework/Headers/cactus_cloud.h | Adds new vendored simulator header for cloud-related helpers. |
| example/ios/Podfile.lock | Updates example app pod lockfile to Cactus 1.10.0. |
Comments suppressed due to low confidence (2)
ios/cactus.xcframework/ios-arm64/cactus.framework/Headers/cactus_utils.h:22
std::getenvis used later in this header (e.g.env_flag_enabled,env_or_default), but<cstdlib>is not included. Some toolchains will fail to compile with “no member named 'getenv' in namespace std”. Add#include <cstdlib>here (or switch to::getenvwith the proper include).
#include "../engine/engine.h"
#include "../models/model.h"
#include <string>
#include <vector>
#include <unordered_map>
#include <stdexcept>
#include <sstream>
#include <iomanip>
#include <fstream>
#include <iostream>
#include <filesystem>
#include <cctype>
#include <algorithm>
#include <cmath>
#include <limits>
#include <memory>
#include <atomic>
#include <mutex>
#include <random>
ios/cactus.xcframework/ios-arm64-simulator/cactus.framework/Headers/cactus_utils.h:22
std::getenvis used later in this header (e.g.env_flag_enabled,env_or_default), but<cstdlib>is not included. Some toolchains will fail to compile with “no member named 'getenv' in namespace std”. Add#include <cstdlib>here (or switch to::getenvwith the proper include).
#include "../engine/engine.h"
#include "../models/model.h"
#include <string>
#include <vector>
#include <unordered_map>
#include <stdexcept>
#include <sstream>
#include <iomanip>
#include <fstream>
#include <iostream>
#include <filesystem>
#include <cctype>
#include <algorithm>
#include <cmath>
#include <limits>
#include <memory>
#include <atomic>
#include <mutex>
#include <random>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.