⚡ Bolt: Prevent intermediate array allocations in CacheoutViewModel#398
⚡ Bolt: Prevent intermediate array allocations in CacheoutViewModel#398acebytes wants to merge 1 commit into
Conversation
Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closing as duplicate — the same lazy-filter optimization in |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
💡 What: Replaced eager array filtering and full map reductions with
.contains(where:)and.lazy.filterinhasSelectionandselectedSize.🎯 Why: Calculating
hasSelectioneagerly allocated intermediate arrays and evaluated the entireselectedNodeModulesSizesum just to check for emptiness, causing unnecessary memory churn and O(N) CPU operations during SwiftUI redraws.📊 Impact: Reduces memory allocations during view updates and changes
hasSelectionto an O(1) best-case short-circuit evaluation.🔬 Measurement: Observe memory footprint and CPU utilization in Instruments (Allocations/Time Profiler) while selecting/deselecting scan results.
PR created automatically by Jules for task 3172167183885227546 started by @acebytes