Skip to content

⚡ Bolt: Prevent intermediate array allocations in CacheoutViewModel#398

Closed
acebytes wants to merge 1 commit into
mainfrom
jules-3172167183885227546-99085593
Closed

⚡ Bolt: Prevent intermediate array allocations in CacheoutViewModel#398
acebytes wants to merge 1 commit into
mainfrom
jules-3172167183885227546-99085593

Conversation

@acebytes

Copy link
Copy Markdown
Contributor

💡 What: Replaced eager array filtering and full map reductions with .contains(where:) and .lazy.filter in hasSelection and selectedSize.
🎯 Why: Calculating hasSelection eagerly allocated intermediate arrays and evaluated the entire selectedNodeModulesSize sum just to check for emptiness, causing unnecessary memory churn and O(N) CPU operations during SwiftUI redraws.
📊 Impact: Reduces memory allocations during view updates and changes hasSelection to an O(1) best-case short-circuit evaluation.
🔬 Measurement: Observe memory footprint and CPU utilization in Instruments (Allocations/Time Profiler) while selecting/deselecting scan results.


PR created automatically by Jules for task 3172167183885227546 started by @acebytes

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@acebytes

Copy link
Copy Markdown
Contributor Author

Closing as duplicate — the same lazy-filter optimization in CacheoutViewModel.swift was already addressed by merged PR #393 (merged earlier today). This PR was generated by the bot concurrently with our triage. The relevant changes are now on main.

@acebytes acebytes closed this Jun 16, 2026
@google-labs-jules

Copy link
Copy Markdown
Contributor

Closing as duplicate — the same lazy-filter optimization in CacheoutViewModel.swift was already addressed by merged PR #393 (merged earlier today). This PR was generated by the bot concurrently with our triage. The relevant changes are now on main.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant