Skip to content

⚡ Bolt: Optimize selection checks to avoid eager array allocations and forced iteration#392

Closed
acebytes wants to merge 1 commit into
mainfrom
bolt-optimize-selection-checks-744518829490326981
Closed

⚡ Bolt: Optimize selection checks to avoid eager array allocations and forced iteration#392
acebytes wants to merge 1 commit into
mainfrom
bolt-optimize-selection-checks-744518829490326981

Conversation

@acebytes

Copy link
Copy Markdown
Contributor

💡 What: Replaced intermediate array allocation in selectedSize with .lazy.filter, and replaced !selectedResults.isEmpty and selectedNodeModulesSize > 0 with .contains(where:) in hasSelection.
🎯 Why: The previous implementation created intermediate arrays or forced full collection traversal just to check for the presence of selected items, leading to unnecessary memory churn and CPU overhead in a SwiftUI @Published view model.
📊 Impact: Reduces memory allocation by avoiding intermediate arrays and changes an O(N) traversal to an O(1) best-case operation due to short-circuit evaluation.
🔬 Measurement: Profile the view model with Instruments (Allocations/Time Profiler) while toggling selection to verify reduced array allocations and traversal overhead.


PR created automatically by Jules for task 744518829490326981 started by @acebytes

…d forced iteration

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@acebytes

Copy link
Copy Markdown
Contributor Author

Closing as duplicate. The Bolt bot has opened many PRs for the same lazy-filter / short-circuit / array-allocation optimizations in CacheoutViewModel.swift and MenuBarView.swift / CleanConfirmation.swift. Consolidating on #393 as the canonical (most recent iteration).

@acebytes acebytes closed this Jun 16, 2026
@google-labs-jules

Copy link
Copy Markdown
Contributor

Closing as duplicate. The Bolt bot has opened many PRs for the same lazy-filter / short-circuit / array-allocation optimizations in CacheoutViewModel.swift and MenuBarView.swift / CleanConfirmation.swift. Consolidating on #393 as the canonical (most recent iteration).

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

@acebytes acebytes deleted the bolt-optimize-selection-checks-744518829490326981 branch June 16, 2026 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant