⚡ Bolt: Optimize selection checks to avoid eager array allocations and forced iteration#392
⚡ Bolt: Optimize selection checks to avoid eager array allocations and forced iteration#392acebytes wants to merge 1 commit into
Conversation
…d forced iteration Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closing as duplicate. The Bolt bot has opened many PRs for the same lazy-filter / short-circuit / array-allocation optimizations in |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
💡 What: Replaced intermediate array allocation in
selectedSizewith.lazy.filter, and replaced!selectedResults.isEmptyandselectedNodeModulesSize > 0with.contains(where:)inhasSelection.🎯 Why: The previous implementation created intermediate arrays or forced full collection traversal just to check for the presence of selected items, leading to unnecessary memory churn and CPU overhead in a SwiftUI
@Publishedview model.📊 Impact: Reduces memory allocation by avoiding intermediate arrays and changes an O(N) traversal to an O(1) best-case operation due to short-circuit evaluation.
🔬 Measurement: Profile the view model with Instruments (Allocations/Time Profiler) while toggling selection to verify reduced array allocations and traversal overhead.
PR created automatically by Jules for task 744518829490326981 started by @acebytes